[GitHub] [iceberg] szehon-ho commented on a diff in pull request #4817: [Core][Spark] Improve DeleteOrphanFiles action to return additional details of deleted orphan files

[GitBox <gi...@apache.org>]

szehon-ho commented on code in PR #4817:
URL: https://github.com/apache/iceberg/pull/4817#discussion_r940706787


##########
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##########
@@ -85,8 +85,33 @@ public interface DeleteOrphanFiles extends Action<DeleteOrphanFiles, DeleteOrpha
    */
   interface Result {
     /**
+     * @deprecated since 0.14.0, will be removed in 0.15.0; use {@link #orphanFiles()} instead.
      * Returns locations of orphan files.
      */
+    @Deprecated
     Iterable<String> orphanFileLocations();
+
+    /**
+     * Returns orphan files.
+     */
+    Iterable<OrphanFileStatus> orphanFiles();

Review Comment:
   I wonder if it makes sense to have a method like, failures() that is dedicated to returning failure statuses.  The status isnt very helpful if the delete was a success



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org