You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/12/03 18:36:38 UTC

[GitHub] yxu-valleytider commented on a change in pull request #6968: [FLINK-4582] [kinesis] Consuming data from DynamoDB streams to flink

yxu-valleytider commented on a change in pull request #6968: [FLINK-4582] [kinesis] Consuming data from DynamoDB streams to flink
URL: https://github.com/apache/flink/pull/6968#discussion_r238386976
 
 

 ##########
 File path: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java
 ##########
 @@ -143,6 +143,34 @@ public SentinelSequenceNumber toSentinelSequenceNumber() {
 	/** The interval after which to consider a shard idle for purposes of watermark generation. */
 	public static final String SHARD_IDLE_INTERVAL_MILLIS = "flink.shard.idle.interval";
 
+  /**
+	 * The base backoff time between each describeStream attempt.
+	 * Different tag name to distinguish from "flink.stream.describe.backoff.base"
+	 * since the latter is deprecated.
+	 */
+	public static final String DYNAMODB_STREAMS_DESCRIBE_BACKOFF_BASE =
 
 Review comment:
   @tweise  are you ok with removing this function `KinesisProxy::replaceDeprecatedConsumerKeys` as well ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services