[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #6304: API, Core: Add groupingKey to ScanTaskGroup

[GitBox <gi...@apache.org>]

RussellSpitzer commented on code in PR #6304:
URL: https://github.com/apache/iceberg/pull/6304#discussion_r1034950972


##########
api/src/main/java/org/apache/iceberg/ScanTaskGroup.java:
##########
@@ -26,6 +26,24 @@
  * @param <T> the type of scan tasks
  */
 public interface ScanTaskGroup<T extends ScanTask> extends ScanTask {
+  /**
+   * Returns a grouping key for this task group.
+   *
+   * <p>Tasks may produce records that belong to a specific group of data (e.g. partition). It may

Review Comment:
   This description is a little too abstract for me to understand what the grouping key is from this doc. I think grouping key needs to be defined first here. Maybe 
   
   "A grouping key is a set of values that are common amongst all rows within all tasks within the group. The values may be the result of transforming the underlying data. For example, a grouping key may have the bucket ordinal computed by applying a bucketing transformation to a column of the underlying rows."
   
   Wdyt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org