You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shai Erera (Issue Comment Edited) (JIRA)" <ji...@apache.org> on 2011/11/14 13:20:51 UTC

[jira] [Issue Comment Edited] (LUCENE-3269) Speed up Top-K sampling tests

    [ https://issues.apache.org/jira/browse/LUCENE-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149600#comment-13149600 ] 

Shai Erera edited comment on LUCENE-3269 at 11/14/11 12:20 PM:
---------------------------------------------------------------

I see what got you confused (it was me, not you):

{quote}
however, if they will run in the same JVM, then they will reuse the already created indexes
{quote}

what I wrote is wrong (I got myself confused !) -- whatever you do in beforeClass affects only that testcase, not all the ones that will run in the JVM. Perhaps JUnit need to invent two more concepts @StartJVM and @EndJVM, for this to happen :)
                
      was (Author: shaie):
    I see what got you confused (it was me, not you):

{quote}
however, if they will run in the same JVM, then they will reuse the already created indexes
{quote}

what I wrote is wrong (I got myself confused (!) -- whatever you do in beforeClass affects only that testcase, not all the ones that will run in the JVM. Perhaps JUnit need to invent two more concepts @StartJVM and @EndJVM, for this to happen :)
                  
> Speed up Top-K sampling tests
> -----------------------------
>
>                 Key: LUCENE-3269
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3269
>             Project: Lucene - Java
>          Issue Type: Test
>          Components: modules/facet
>            Reporter: Robert Muir
>            Assignee: Shai Erera
>             Fix For: 3.5, 4.0
>
>         Attachments: LUCENE-3269.patch, LUCENE-3269.patch, LUCENE-3269.patch, LUCENE-3269.patch
>
>
> speed up the top-k sampling tests (but make sure they are thorough on nightly etc still)
> usually we would do this with use of atLeast(), but these tests are somewhat tricky,
> so maybe a different approach is needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org