You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "hboutemy (via GitHub)" <gi...@apache.org> on 2026/03/16 11:39:35 UTC
[PR] run assembly only on root project [maven-mvnd]
hboutemy opened a new pull request, #1554:
URL: https://github.com/apache/maven-mvnd/pull/1554
before the change:
```
$ find . -name '*-src.zip'
./build-plugin/target/maven-mvnd-1.0.4-src.zip
./agent/target/maven-mvnd-1.0.4-src.zip
./client/target/maven-mvnd-1.0.4-src.zip
./dist/target/maven-mvnd-1.0.4-src.zip
./target/maven-mvnd-1.0.4-src.zip
./common/target/maven-mvnd-1.0.4-src.zip
./integration-tests/target/maven-mvnd-1.0.4-src.zip
./daemon/target/maven-mvnd-1.0.4-src.zip
./logging/target/maven-mvnd-1.0.4-src.zip
./native/target/maven-mvnd-1.0.4-src.zip
./helper/target/maven-mvnd-1.0.4-src.zip
```
not really a big problem, but it will be more efficient and clear to keep the assembly at root project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] run assembly only on root project [maven-mvnd]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy merged PR #1554:
URL: https://github.com/apache/maven-mvnd/pull/1554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] run assembly only on root project [maven-mvnd]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1554:
URL: https://github.com/apache/maven-mvnd/pull/1554#issuecomment-4067875795
Hm, thinking and few remarks:
* The `source-distribution` profile is used in conjunction with `-N` CLI option, so only "top module" is invoked to build source distribution.
* Why not just add `<inherited>false</inherited>` to plugin? The change in this PR would still invoke the plugin, but the plugin logic would decide to return without doing anything (waste of cycles), while with `inherited=false` the plugin would not be invoked at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] run assembly only on root project [maven-mvnd]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on PR #1554:
URL: https://github.com/apache/maven-mvnd/pull/1554#issuecomment-4072972896
the use of `-N` is quite unknown to many, but you're right
I love the `<inherited>false</inherited>` approach: sold :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org