You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Na Li <li...@cloudera.com> on 2017/08/11 19:12:36 UTC

Review Request 61598: SENTRY-1856: Persisting HMS snapshot and the notification-id to database in same transaction

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61598/
-----------------------------------------------------------

Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar kalvagadda, and Vamsee Yarlagadda.


Repository: sentry


Description
-------

when saving full snapshot, save its latest notification ID as well


Diffs
-----

  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 4305691 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java b0a202e 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java ccfb5ab 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java d44212f 


Diff: https://reviews.apache.org/r/61598/diff/1/


Testing
-------

unit test


Thanks,

Na Li


Re: Review Request 61598: SENTRY-1856: Persisting HMS snapshot and the notification-id to database in same transaction

Posted by Brian Towles <bt...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61598/#review182908
-----------------------------------------------------------


Ship it!




Ship It!

- Brian Towles


On Aug. 14, 2017, 1:35 p.m., Na Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61598/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2017, 1:35 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar kalvagadda, and Vamsee Yarlagadda.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> when saving full snapshot, save its latest notification ID as well
> 
> 
> Diffs
> -----
> 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 4305691 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java b0a202e 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java ccfb5ab 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java d44212f 
> 
> 
> Diff: https://reviews.apache.org/r/61598/diff/2/
> 
> 
> Testing
> -------
> 
> unit test
> 
> 
> Thanks,
> 
> Na Li
> 
>


Re: Review Request 61598: SENTRY-1856: Persisting HMS snapshot and the notification-id to database in same transaction

Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61598/#review182903
-----------------------------------------------------------


Ship it!




Ship It!

- Vamsee Yarlagadda


On Aug. 14, 2017, 6:35 p.m., Na Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61598/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2017, 6:35 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar kalvagadda, and Vamsee Yarlagadda.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> when saving full snapshot, save its latest notification ID as well
> 
> 
> Diffs
> -----
> 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 4305691 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java b0a202e 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java ccfb5ab 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java d44212f 
> 
> 
> Diff: https://reviews.apache.org/r/61598/diff/2/
> 
> 
> Testing
> -------
> 
> unit test
> 
> 
> Thanks,
> 
> Na Li
> 
>


Re: Review Request 61598: SENTRY-1856: Persisting HMS snapshot and the notification-id to database in same transaction

Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61598/
-----------------------------------------------------------

(Updated Aug. 14, 2017, 6:35 p.m.)


Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar kalvagadda, and Vamsee Yarlagadda.


Repository: sentry


Description
-------

when saving full snapshot, save its latest notification ID as well


Diffs (updated)
-----

  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 4305691 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java b0a202e 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java ccfb5ab 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java d44212f 


Diff: https://reviews.apache.org/r/61598/diff/2/

Changes: https://reviews.apache.org/r/61598/diff/1-2/


Testing
-------

unit test


Thanks,

Na Li


Re: Review Request 61598: SENTRY-1856: Persisting HMS snapshot and the notification-id to database in same transaction

Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61598/#review182769
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Kolbasov


On Aug. 11, 2017, 7:12 p.m., Na Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61598/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2017, 7:12 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar kalvagadda, and Vamsee Yarlagadda.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> when saving full snapshot, save its latest notification ID as well
> 
> 
> Diffs
> -----
> 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 4305691 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java b0a202e 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java ccfb5ab 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java d44212f 
> 
> 
> Diff: https://reviews.apache.org/r/61598/diff/1/
> 
> 
> Testing
> -------
> 
> unit test
> 
> 
> Thanks,
> 
> Na Li
> 
>


Re: Review Request 61598: SENTRY-1856: Persisting HMS snapshot and the notification-id to database in same transaction

Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61598/#review182738
-----------------------------------------------------------


Ship it!




Ship It!

- kalyan kumar kalvagadda


On Aug. 11, 2017, 7:12 p.m., Na Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61598/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2017, 7:12 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar kalvagadda, and Vamsee Yarlagadda.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> when saving full snapshot, save its latest notification ID as well
> 
> 
> Diffs
> -----
> 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 4305691 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java b0a202e 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java ccfb5ab 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java d44212f 
> 
> 
> Diff: https://reviews.apache.org/r/61598/diff/1/
> 
> 
> Testing
> -------
> 
> unit test
> 
> 
> Thanks,
> 
> Na Li
> 
>