You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by GitBox <gi...@apache.org> on 2021/03/13 10:47:32 UTC

[GitHub] [jspwiki] arturobernalg opened a new pull request #47: JSPWIKI-1148 - Avoid File Stream

arturobernalg opened a new pull request #47:
URL: https://github.com/apache/jspwiki/pull/47


   Replace construction of FileInputStream and FileOutputStream objects with Files NIO APIs.
   Please note, that the java.nio API does not throw a FileNotFoundException anymore, instead it throws a NoSuchFileException. 
    
   https://github.com/apache/jspwiki/blob/master/jspwiki-util/src/main/java/org/apache/wiki/util/PropertyReader.java#L144


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jspwiki] arturobernalg commented on a change in pull request #47: JSPWIKI-1148 - Avoid File Stream

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #47:
URL: https://github.com/apache/jspwiki/pull/47#discussion_r593736743



##########
File path: jspwiki-util/src/main/java/org/apache/wiki/util/PropertyReader.java
##########
@@ -141,15 +142,15 @@ public static Properties loadWebAppProps( final ServletContext context ) {
      * @return inputstream holding the properties file
      * @throws FileNotFoundException properties file not found
      */
-	static InputStream loadCustomPropertiesFile( final ServletContext context, final String propertyFile ) throws FileNotFoundException {
+	static InputStream loadCustomPropertiesFile( final ServletContext context, final String propertyFile ) throws IOException {

Review comment:
       @juanpablo-santos
   Special careful here. Signature changed. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jspwiki] arturobernalg commented on pull request #47: JSPWIKI-1148 - Avoid File Stream

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #47:
URL: https://github.com/apache/jspwiki/pull/47#issuecomment-926032053


   > Hi @arturobernalg ,
   > 
   > apologies for the long delay looking at this PR. I'm +1 on merging it, however, would you mind pls rebasing with latest commits?
   > 
   > As for the signature change, that method is package-protected and seems to be used only by the `loadWebAppProps` method on the same class, and handled by its `try..catch` block, so it shouldn't be a big deal..
   > 
   > best regards,
   > juan pablo
   
   HI @juanpablo-santos , rebase from master. I think all the changes are already made previously.
   TY


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jspwiki] juanpablo-santos commented on pull request #47: JSPWIKI-1148 - Avoid File Stream

Posted by GitBox <gi...@apache.org>.
juanpablo-santos commented on pull request #47:
URL: https://github.com/apache/jspwiki/pull/47#issuecomment-917016622


   Hi @arturobernalg ,
   
   apologies for the long delay looking at this PR. I'm +1 on merging it, however, would you mind pls rebasing with latest commits? 
   
   As for the signature change, that method is package-protected and seems to be used only by the `loadWebAppProps` method on the same class, and handled by its `try..catch` block, so it shouldn't be a big deal..
   
   
   best regards,
   juan pablo


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jspwiki] arturobernalg commented on a change in pull request #47: JSPWIKI-1148 - Avoid File Stream

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #47:
URL: https://github.com/apache/jspwiki/pull/47#discussion_r593736743



##########
File path: jspwiki-util/src/main/java/org/apache/wiki/util/PropertyReader.java
##########
@@ -141,15 +142,15 @@ public static Properties loadWebAppProps( final ServletContext context ) {
      * @return inputstream holding the properties file
      * @throws FileNotFoundException properties file not found
      */
-	static InputStream loadCustomPropertiesFile( final ServletContext context, final String propertyFile ) throws FileNotFoundException {
+	static InputStream loadCustomPropertiesFile( final ServletContext context, final String propertyFile ) throws IOException {

Review comment:
       @juanpablo-santos
   Be Careful here. Signature changed. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jspwiki] juanpablo-santos merged pull request #47: JSPWIKI-1148 - Avoid File Stream

Posted by GitBox <gi...@apache.org>.
juanpablo-santos merged pull request #47:
URL: https://github.com/apache/jspwiki/pull/47


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jspwiki] arturobernalg commented on pull request #47: JSPWIKI-1148 - Avoid File Stream

Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #47:
URL: https://github.com/apache/jspwiki/pull/47#issuecomment-816833637


   @juanpablo-santos 
   Happy easter men. 
   
   ping here ;) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org