[jira] [Commented] (DRILL-5771) Fix serDe errors for format plugins

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-5771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222504#comment-16222504 ] 

ASF GitHub Bot commented on DRILL-5771:
---------------------------------------

GitHub user arina-ielchiieva opened a pull request:

    https://github.com/apache/drill/pull/1014

    DRILL-5771: Fix serDe errors for format plugins

    1. Fix various serde issues for format plugins described in [DRILL-5771](https://issues.apache.org/jira/browse/DRILL-5771).
    2. Throw meaninful exception instead of NPE when table is not found when table function is used.
    3. Add unit tests for all format plugins for ensure serde is checked (physical plan is generated in json format and then submitted).
    4. Fix physical plan submission on Windows ([DRILL-4640](https://issues.apache.org/jira/browse/DRILL-4640)).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arina-ielchiieva/drill DRILL-5771

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1014.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1014
    
----
commit 72544d5aa9f0add3075c2eb174c49b355d3c85e2
Author: Arina Ielchiieva <ar...@gmail.com>
Date:   2017-10-26T13:09:00Z

    DRILL-5771: Fix serDe errors for format plugins
    
    1. Fix various serde issues for format plugins described in DRILL-5771.
    2. Throw meaninful exception instead of NPE when table is not found when table function is used.
    3. Added unit tests for all format plugins for ensure serde is checked (physical plan is generated in json format and then submitted).
    4. Fix physical plan submission on Windows (DRILL-4640).

----


> Fix serDe errors for format plugins
> -----------------------------------
>
>                 Key: DRILL-5771
>                 URL: https://issues.apache.org/jira/browse/DRILL-5771
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.11.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>            Priority: Minor
>
> Create unit tests to check that all storage format plugins can be successfully serialized  / deserialized.
> Usually this happens when query has several major fragments. 
> One way to check serde is to generate physical plan (generated as json) and then submit it back to Drill.
> One example of found errors is described in the first comment. Another example is described in DRILL-5166.
> *Serde issues:*
> 1. Could not obtain format plugin during deserialization
> Format plugin is created based on format plugin configuration or its name. 
> On Drill start up we load information about available plugins (its reloaded each time storage plugin is updated, can be done only by admin).
> When query is parsed, we try to get plugin from the available ones, it we can not find one we try to [create one|https://github.com/apache/drill/blob/3e8b01d5b0d3013e3811913f0fd6028b22c1ac3f/exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemPlugin.java#L136-L144]
> but on other query execution stages we always assume that [plugin exists based on configuration|https://github.com/apache/drill/blob/3e8b01d5b0d3013e3811913f0fd6028b22c1ac3f/exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemPlugin.java#L156-L162].
> For example, during query parsing we had to create format plugin on one node based on format configuration.
> Then we have sent major fragment to the different node where we used this format configuration we could not get format plugin based on it and deserialization has failed.
> To fix this problem we need to create format plugin during query deserialization if it's absent.
>   
> 2.  Absent hash code and equals.
> Format plugins are stored in hash map where key is format plugin config.
> Since some format plugin configs did not have overridden hash code and equals, we could not find format plugin based on its configuration.
> 3. Named format plugin usage
> Named format plugins configs allow to get format plugin by its name for configuration shared among all drillbits.
> They are used as alias for pre-configured format plugiins. User with admin priliges can modify them at runtime.
> Named format plugins configs are used instead of sending all non-default parameters of format plugin config, in this case only name is sent.
> Their usage in distributed system may cause raise conditions.
> For example, 
> 1. Query is submitted. 
> 2. Parquet format plugin is created with the following configuration (autoCorrectCorruptDates=>true).
> 3. Seralized named format plugin config with name as parquet.
> 4. Major fragment is sent to the different node.
> 5. Admin has changed parquet configuration for the alias 'parquet' on all nodes to autoCorrectCorruptDates=>false.
> 6. Named format is deserialized on the different node into parquet format plugin with configuration (autoCorrectCorruptDates=>false).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)