[GitHub] [flink] tillrohrmann commented on issue #11353: [FLINK-16438][yarn] Make YarnResourceManager starts workers using WorkerResourceSpec requested by SlotManager

[GitBox <gi...@apache.org>]

tillrohrmann commented on issue #11353: [FLINK-16438][yarn] Make YarnResourceManager starts workers using WorkerResourceSpec requested by SlotManager
URL: https://github.com/apache/flink/pull/11353#issuecomment-609847398
 
 
   I would name the methods the following:
   
   * `getNumPendingWorkers()`
   * `getNumPendingWorkersFor(WorkerResourceSpec workerResourceSpec)`
   * `notifyNewWorkerRequested(WRS wrs)`
   * `notifyNewWorkerAllocated(WRS wrs)`
   
   I actually think that neither the Yarn nor the K8s `RM` implementation should need to call these methods if we did the abstraction correctly. This is of course unrelated to these PRs. I believe that we could move a lot of functionality from the specific implementation into the parent class.
   
   I don't have a strong preference concerning how to split the changes. Do what's easiest for you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services