[GitHub] spark pull request: [SPARK-12117][SQL] Fix ignored column aliases ...

[frreiss <gi...@git.apache.org>]

Github user frreiss commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10140#discussion_r55431942
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala ---
    @@ -23,6 +23,15 @@ import org.apache.spark.sql.catalyst.errors.attachTree
     import org.apache.spark.sql.catalyst.expressions.codegen.{CodeGenContext, GeneratedExpressionCode}
     import org.apache.spark.sql.types._
     
    +object BoundReference {
    +  def apply(
    --- End diff --
    
    Are you sure you want the name parameter to be optional? The bug in the original JIRA might pop up again if there's another code path that produces instances of BoundReference without name metadata in the plan.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org