You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/09/26 15:25:00 UTC

[jira] [Commented] (AIRFLOW-5561) Very old version of httplib2 installed when using gcp extra

    [ https://issues.apache.org/jira/browse/AIRFLOW-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938721#comment-16938721 ] 

ASF GitHub Bot commented on AIRFLOW-5561:
-----------------------------------------

camilomartinez commented on pull request #6194: [AIRFLOW-5561] Relax httplib2 version required for gcp extra
URL: https://github.com/apache/airflow/pull/6194
 
 
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5561
   
   ### Description
   
   As part of [AIRFLOW-3971] a minor version range dependency was
   introduced that means that only older versions of httplib2 can
   be used.
   
   I'm relaxing this dependency as I tested with the latest 0.13.1
   and it works correctly
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Very old version of httplib2 installed when using gcp extra
> -----------------------------------------------------------
>
>                 Key: AIRFLOW-5561
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5561
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: gcp
>    Affects Versions: 1.10.3, 1.10.4, 1.10.5
>            Reporter: Camilo Martinez
>            Priority: Major
>
> After starting to use poetry to properly resolve airflow dependencies I faced network issues that I pinpointed to httplib2 interactions with proxy in my corporate network.
> When making an http request I would get a "Network not reachable" exception
> I isolated the problem to happen when using a very old version of httplib2 while using gcp extra which has a dependency range too strict (~=0.9.2)
> I noticed that this dependency used to be httplib2>=0.9.2 and it was changed as part of AIRFLOW-3971  commit (91b856f) without a clear reason why a more strict dependency is needed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)