You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Paul Querna <ch...@force-elite.com> on 2005/08/14 03:12:17 UTC
APR-Util 1.2.1
APR-Util 1.2.1 is now available from:
http://people.apache.org/~pquerna/dev/apu-1.2.1/
Please test and vote on releasing it.
Thanks,
Paul
Re: APR-Util 1.2.1
Posted by Joe Orton <jo...@redhat.com>.
+1 to both the apr-1.2.1 and apr-util 1.2.1 tarballs, testall passes for
both on:
PASS: RHEL2.1/i686 RHEL3/i686 RHEL4/i686 FC3/i686 RHEL3/i686 RHEL4/ppc RawHide/ppc
RHEL4/x86_64 FC3/i686
Thanks Paul.
joe
Re: APR-Util 1.2.1
Posted by Graham Leggett <mi...@sharp.fm>.
Paul Querna wrote:
> APR-Util 1.2.1 is now available from:
> http://people.apache.org/~pquerna/dev/apu-1.2.1/
+1 built as RPMs on RHEL4.
Regards,
Graham
--
Re: APR-Util 1.2.1
Posted by Brad Nicholes <bn...@novell.com>.
+1 NetWare
Brad
>>> On Saturday, August 13, 2005 at 7:12 pm, in message
<42...@force-elite.com>, Paul Querna <ch...@force-elite.com>
wrote:
> APR-Util 1.2.1 is now available from:
> http://people.apache.org/~pquerna/dev/apu-1.2.1/
>
> Please test and vote on releasing it.
>
> Thanks,
>
> Paul
Re: APR-Util 1.2.1
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
Paul Querna wrote:
> APR-Util 1.2.1 is now available from:
> http://people.apache.org/~pquerna/dev/apu-1.2.1/
>
> Please test and vote on releasing it.
>
> Thanks,
>
> Paul
>
>
+1 on both Mac OS X and Linux. Same problem with needing to make
install before make test will work on Mac OS X, but like I said, no big
deal. I also noticed some warnings in the dbd test code, and those are
now fixed on the trunk, but I don't think that's important enough to
reroll a release on.
-garrett
Re: APR-Util 1.2.1
Posted by Paul Querna <ch...@force-elite.com>.
Jeff Trawick wrote:
> On 8/14/05, Branko Čibej <br...@xbc.nu> wrote:
>
>>Paul Querna wrote:
>>
>>
>>>APR-Util 1.2.1 is now available from:
>>>http://people.apache.org/~pquerna/dev/apu-1.2.1/
>>>
>>>Please test and vote on releasing it.
>>>
>>>
>>
>>Where's apr-iconv? This stuff won't work without it on Windows.
>
>
> What's the resolution to this for apr/apu 1.2.1? Use the
> previously-released apr-iconv?
Yup.
There haven't been any changes to APR-Iconv, AFAIK.
Re: APR-Util 1.2.1
Posted by Jeff Trawick <tr...@gmail.com>.
On 8/14/05, Branko Čibej <br...@xbc.nu> wrote:
> Paul Querna wrote:
>
> >APR-Util 1.2.1 is now available from:
> >http://people.apache.org/~pquerna/dev/apu-1.2.1/
> >
> >Please test and vote on releasing it.
> >
> >
> Where's apr-iconv? This stuff won't work without it on Windows.
What's the resolution to this for apr/apu 1.2.1? Use the
previously-released apr-iconv?
Re: APR-Util 1.2.1
Posted by Branko Čibej <br...@xbc.nu>.
Paul Querna wrote:
>APR-Util 1.2.1 is now available from:
>http://people.apache.org/~pquerna/dev/apu-1.2.1/
>
>Please test and vote on releasing it.
>
>
Where's apr-iconv? This stuff won't work without it on Windows.
-- Brane
Re: APR-Util 1.2.1
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
Rick Keiner wrote:
> Hi Garret,
>
> Will this patch get in 1.2.1? If not, the SQLite3
> driver will not support Float values.
I suspect not, since you didn't even post it until after Paul had tagged
1.2.1. There's no reason I can see that it can't make it in to another
1.2.x release though, since it doesn't modify the public API.
-garrett
Re: APR-Util 1.2.1
Posted by Nick Kew <ni...@webthing.com>.
On Friday 19 August 2005 03:58, Rick Keiner wrote:
> Hi Garret,
>
> Will this patch get in 1.2.1? If not, the SQLite3
> driver will not support Float values.
Too late for 1.2.1, but I've just committed the patch in Trunk so it should
make it into the next release, if nothing bad happens.
--
Nick Kew
Re: APR-Util 1.2.1
Posted by Rick Keiner <ri...@yahoo.com>.
Hi Garret,
Will this patch get in 1.2.1? If not, the SQLite3
driver will not support Float values.
Rick Keiner
--- Rick Keiner <ri...@yahoo.com> wrote:
> Hi Garrett,
>
> Sure, no problem.
>
> 1) relock the mutex after a retry in the
> dbd_sqlite3_select function.
>
> 2) remove break from the return of a float value
> from
> SQLite and initialize the value to NULL. The value
> was
> never being returned.
>
> 3) remove unnecessary creation and destruction of
> apr_pool in dbd_sqlite3_query function.
>
> 4) Remove the res variable in the dbd_sqlite3_query
> function.
>
> There were some changes after this review and the
> updated patch file is attached.
>
> Thanks,
> Rick Keiner
>
> --- Garrett Rooney <ro...@electricjellyfish.net>
> wrote:
>
> > Rick Keiner wrote:
> > > Hi Paul,
> > >
> > > I've attached a patch to the SQLite 3 driver
> that
> > > fixes some initialization issues and returns
> float
> > > data. This has been tested with the
> > jxta-c.jxta.org
> > > project and no major issues. If we could get it
> in
> > the
> > > release that would be great! We are relying on
> > this
> > > patch to be part of the release.
> >
> > I'd love to commit this patch, but it seems to do
> a
> > number of different
> > things, and since I don't know all that much about
> > the internals of the
> > sqlite3 dbd I can't confirm if they're right or
> > wrong. Could you
> > perhaps write a log message that explains exactly
> > what problems are
> > being corrected here (in addition to the addition
> of
> > the new float data
> > feature).
> >
> > Thanks,
> >
> > -garrett
> > > Index: dbd/apr_dbd_sqlite3.c
>
===================================================================
> --- dbd/apr_dbd_sqlite3.c (revision 232627)
> +++ dbd/apr_dbd_sqlite3.c (working copy)
> @@ -117,6 +117,7 @@
> } else {
>
> apr_thread_mutex_unlock(sql->mutex);
> apr_sleep(MAX_RETRY_SLEEP);
> +
> apr_thread_mutex_lock(sql->mutex);
> }
> } else if (ret == SQLITE_ROW) {
> int length;
> @@ -134,23 +135,22 @@
> column->name = (char *)
> sqlite3_column_name((*results)->stmt, i);
> column->size =
> sqlite3_column_bytes((*results)->stmt, i);
> column->type =
> sqlite3_column_type((*results)->stmt, i);
> + column->value = NULL;
> switch (column->type) {
> -
> - case SQLITE_FLOAT:
> - break;
> - case SQLITE_INTEGER:
> - case SQLITE_TEXT:
> - hold = NULL;
> - hold = (char *)
> sqlite3_column_text((*results)->stmt, i);
> - if (hold) {
> - column->value =
> apr_palloc(pool, column->size + 1);
> - strncpy(column->value,
> hold, column->size + 1);
> - }
> - break;
> - case SQLITE_BLOB:
> - break;
> - case SQLITE_NULL:
> - break;
> + case SQLITE_FLOAT:
> + case SQLITE_INTEGER:
> + case SQLITE_TEXT:
> + hold = NULL;
> + hold = (char *)
> sqlite3_column_text((*results)->stmt, i);
> + if (hold) {
> + column->value =
> apr_palloc(pool, column->size + 1);
> +
> strncpy(column->value, hold, column->size + 1);
> + }
> + break;
> + case SQLITE_BLOB:
> + break;
> + case SQLITE_NULL:
> + break;
> }
> col = row->columns[i];
> }
> @@ -226,19 +226,12 @@
> {
> sqlite3_stmt *stmt = NULL;
> const char *tail = NULL;
> - int ret, length = 0;
> - apr_status_t res;
> - apr_pool_t *pool;
> + int ret = -1, length = 0;
>
> if (sql->trans && sql->trans->errnum) {
> return sql->trans->errnum;
> }
>
> - res = apr_pool_create(&pool, sql->pool);
> - if (res != APR_SUCCESS) {
> - sql->trans->errnum = res;
> - return SQLITE_ERROR;
> - }
> length = strlen(query);
> apr_thread_mutex_lock(sql->mutex);
>
> @@ -248,7 +241,6 @@
> sqlite3_finalize(stmt);
> break;
> }
> -
> ret = sqlite3_step(stmt);
> *nrows = sqlite3_changes(sql->conn);
> sqlite3_finalize(stmt);
> @@ -257,14 +249,13 @@
> } while (length > 0);
>
> if (dbd_sqlite3_is_success(ret)) {
> - res = 0;
> + ret = 0;
> }
> apr_thread_mutex_unlock(sql->mutex);
> - apr_pool_destroy(pool);
> if (sql->trans) {
> - sql->trans->errnum = res;
> + sql->trans->errnum = ret;
> }
> - return res;
> + return ret;
> }
>
> static const char *dbd_sqlite3_escape(apr_pool_t
> *pool, const char *arg,
>
>
Re: APR-Util 1.2.1
Posted by Rick Keiner <ri...@yahoo.com>.
Hi Garrett,
Sure, no problem.
1) relock the mutex after a retry in the
dbd_sqlite3_select function.
2) remove break from the return of a float value from
SQLite and initialize the value to NULL. The value was
never being returned.
3) remove unnecessary creation and destruction of
apr_pool in dbd_sqlite3_query function.
4) Remove the res variable in the dbd_sqlite3_query
function.
There were some changes after this review and the
updated patch file is attached.
Thanks,
Rick Keiner
--- Garrett Rooney <ro...@electricjellyfish.net>
wrote:
> Rick Keiner wrote:
> > Hi Paul,
> >
> > I've attached a patch to the SQLite 3 driver that
> > fixes some initialization issues and returns float
> > data. This has been tested with the
> jxta-c.jxta.org
> > project and no major issues. If we could get it in
> the
> > release that would be great! We are relying on
> this
> > patch to be part of the release.
>
> I'd love to commit this patch, but it seems to do a
> number of different
> things, and since I don't know all that much about
> the internals of the
> sqlite3 dbd I can't confirm if they're right or
> wrong. Could you
> perhaps write a log message that explains exactly
> what problems are
> being corrected here (in addition to the addition of
> the new float data
> feature).
>
> Thanks,
>
> -garrett
>
Re: APR-Util 1.2.1
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
Rick Keiner wrote:
> Hi Paul,
>
> I've attached a patch to the SQLite 3 driver that
> fixes some initialization issues and returns float
> data. This has been tested with the jxta-c.jxta.org
> project and no major issues. If we could get it in the
> release that would be great! We are relying on this
> patch to be part of the release.
I'd love to commit this patch, but it seems to do a number of different
things, and since I don't know all that much about the internals of the
sqlite3 dbd I can't confirm if they're right or wrong. Could you
perhaps write a log message that explains exactly what problems are
being corrected here (in addition to the addition of the new float data
feature).
Thanks,
-garrett
Re: APR-Util 1.2.1
Posted by Rick Keiner <ri...@yahoo.com>.
Hi Paul,
I've attached a patch to the SQLite 3 driver that
fixes some initialization issues and returns float
data. This has been tested with the jxta-c.jxta.org
project and no major issues. If we could get it in the
release that would be great! We are relying on this
patch to be part of the release.
Rick Keiner
--- Paul Querna <ch...@force-elite.com> wrote:
> APR-Util 1.2.1 is now available from:
> http://people.apache.org/~pquerna/dev/apu-1.2.1/
>
> Please test and vote on releasing it.
>
> Thanks,
>
> Paul
>