You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/09/08 21:00:52 UTC
[GitHub] [hadoop-ozone] amaliujia opened a new pull request #1410: HDDS-3102. ozone getconf command should use the GenericCli parent class
amaliujia opened a new pull request #1410:
URL: https://github.com/apache/hadoop-ozone/pull/1410
## What changes were proposed in this pull request?
org.apache.hadoop.ozone.freon.OzoneGetCOnf implements a tool to print out current configuration values
With all the other CLI tools we already started to use picocli and the GenericCli parent class.
To provide better user experience we should migrate the tool to use GenericCli (+move it to the tools project + remove freon from the package name)
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3102
## How was this patch tested?
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] amaliujia commented on pull request #1410: HDDS-3102. ozone getconf command should use the GenericCli parent class
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1410:
URL: https://github.com/apache/hadoop-ozone/pull/1410#issuecomment-689134002
@elek Any suggestion on how to test this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] amaliujia commented on pull request #1410: HDDS-3102. ozone getconf command should use the GenericCli parent class
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1410:
URL: https://github.com/apache/hadoop-ozone/pull/1410#issuecomment-692163791
@elek friendly ping on this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1410: HDDS-3102. ozone getconf command should use the GenericCli parent class
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1410:
URL: https://github.com/apache/hadoop-ozone/pull/1410#issuecomment-690929244
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] amaliujia commented on pull request #1410: HDDS-3102. ozone getconf command should use the GenericCli parent class
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1410:
URL: https://github.com/apache/hadoop-ozone/pull/1410#issuecomment-691320364
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] amaliujia commented on pull request #1410: HDDS-3102. ozone getconf command should use the GenericCli parent class
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1410:
URL: https://github.com/apache/hadoop-ozone/pull/1410#issuecomment-691324990
note that because the `getconf.robot` is under `basic` directory, it will be picked up by `compose/ozone/test.sh`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] amaliujia commented on pull request #1410: HDDS-3102. ozone getconf command should use the GenericCli parent class
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1410:
URL: https://github.com/apache/hadoop-ozone/pull/1410#issuecomment-691320364
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] amaliujia commented on pull request #1410: HDDS-3102. ozone getconf command should use the GenericCli parent class
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1410:
URL: https://github.com/apache/hadoop-ozone/pull/1410#issuecomment-691320364
@elek
Thanks for your help! I have added a robot test. Can you take a look please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] amaliujia commented on pull request #1410: HDDS-3102. ozone getconf command should use the GenericCli parent class
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1410:
URL: https://github.com/apache/hadoop-ozone/pull/1410#issuecomment-691320364
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1410: HDDS-3102. ozone getconf command should use the GenericCli parent class
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1410:
URL: https://github.com/apache/hadoop-ozone/pull/1410#issuecomment-690929244
The easiest way IMHO to test cli is adding a robot test.
A simple example is here:
https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/dist/src/main/smoketest/freon/freon.robot
But `Wait Until Keyword Succeeds 3min 10sec ` is not required, just the `Should contain....`
you can easily test robot files with
```
docker-compsoe exec scm bash
robot smoketest/basic/getconf.robot
```
And it can be added to one of the `test.sh` (eg. compose/ozone/test.sh) to be part of the CI tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek merged pull request #1410: HDDS-3102. ozone getconf command should use the GenericCli parent class
Posted by GitBox <gi...@apache.org>.
elek merged pull request #1410:
URL: https://github.com/apache/hadoop-ozone/pull/1410
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1410: HDDS-3102. ozone getconf command should use the GenericCli parent class
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1410:
URL: https://github.com/apache/hadoop-ozone/pull/1410#issuecomment-690929244
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org