You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Mohamed Nufail (JIRA)" <ji...@apache.org> on 2012/06/27 08:53:44 UTC
[jira] [Created] (DERBY-5833) Remove unused methods in
NetCallableStatement class
Mohamed Nufail created DERBY-5833:
-------------------------------------
Summary: Remove unused methods in NetCallableStatement class
Key: DERBY-5833
URL: https://issues.apache.org/jira/browse/DERBY-5833
Project: Derby
Issue Type: Task
Components: Network Client
Reporter: Mohamed Nufail
Priority: Minor
The following methods in NetCallableStatement class seem to be dead code. It might be possible to remove them.
- resetNetCallableStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section)
- resetNetCallableStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section, ColumnMetaData parameterMetaData, ColumnMetaData resultSetMetaData)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5833) Remove unused methods in
NetCallableStatement class
Posted by "Mohamed Nufail (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mohamed Nufail updated DERBY-5833:
----------------------------------
Attachment: derby-5833.patch
Attached file derby-5833.patch removes these two methods.
> Remove unused methods in NetCallableStatement class
> ---------------------------------------------------
>
> Key: DERBY-5833
> URL: https://issues.apache.org/jira/browse/DERBY-5833
> Project: Derby
> Issue Type: Task
> Components: Network Client
> Reporter: Mohamed Nufail
> Priority: Minor
> Attachments: derby-5833.patch
>
>
> The following methods in NetCallableStatement class seem to be dead code. It might be possible to remove them.
> - resetNetCallableStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section)
> - resetNetCallableStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section, ColumnMetaData parameterMetaData, ColumnMetaData resultSetMetaData)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (DERBY-5833) Remove unused methods in
NetCallableStatement class
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Pendleton reassigned DERBY-5833:
--------------------------------------
Assignee: Mohamed Nufail
> Remove unused methods in NetCallableStatement class
> ---------------------------------------------------
>
> Key: DERBY-5833
> URL: https://issues.apache.org/jira/browse/DERBY-5833
> Project: Derby
> Issue Type: Task
> Components: Network Client
> Reporter: Mohamed Nufail
> Assignee: Mohamed Nufail
> Priority: Minor
> Attachments: derby-5833.patch
>
>
> The following methods in NetCallableStatement class seem to be dead code. It might be possible to remove them.
> - resetNetCallableStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section)
> - resetNetCallableStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section, ColumnMetaData parameterMetaData, ColumnMetaData resultSetMetaData)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DERBY-5833) Remove unused methods in
NetCallableStatement class
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Pendleton resolved DERBY-5833.
------------------------------------
Resolution: Fixed
Fix Version/s: 10.10.0.0
I checked the svn history for NetCallableStatement.java and
this code was introduced as part of the original contribution
to Derby, and has not been modified since.
I searched the codebase and agree that these two methods
are unused.
Of the two remaining overloads of resetNetCallableStatement,
it seems that the 3-argument version is called only internally,
by the 6-argument version, so it should be possible, if we so
chose, to make the 3-argument version private, as part of some
future change.
My builds and tests were successful, so I committed the
patch to the trunk as revision 1356066.
> Remove unused methods in NetCallableStatement class
> ---------------------------------------------------
>
> Key: DERBY-5833
> URL: https://issues.apache.org/jira/browse/DERBY-5833
> Project: Derby
> Issue Type: Task
> Components: Network Client
> Reporter: Mohamed Nufail
> Assignee: Mohamed Nufail
> Priority: Minor
> Fix For: 10.10.0.0
>
> Attachments: derby-5833.patch
>
>
> The following methods in NetCallableStatement class seem to be dead code. It might be possible to remove them.
> - resetNetCallableStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section)
> - resetNetCallableStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section, ColumnMetaData parameterMetaData, ColumnMetaData resultSetMetaData)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DERBY-5833) Remove unused methods in
NetCallableStatement class
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan closed DERBY-5833.
----------------------------------
> Remove unused methods in NetCallableStatement class
> ---------------------------------------------------
>
> Key: DERBY-5833
> URL: https://issues.apache.org/jira/browse/DERBY-5833
> Project: Derby
> Issue Type: Task
> Components: Network Client
> Reporter: Mohamed Nufail
> Assignee: Mohamed Nufail
> Priority: Minor
> Fix For: 10.10.0.0
>
> Attachments: derby-5833.patch
>
>
> The following methods in NetCallableStatement class seem to be dead code. It might be possible to remove them.
> - resetNetCallableStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section)
> - resetNetCallableStatement(NetAgent netAgent, NetConnection netConnection, String sql, Section section, ColumnMetaData parameterMetaData, ColumnMetaData resultSetMetaData)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira