You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-commits@hadoop.apache.org by el...@apache.org on 2013/01/08 23:43:41 UTC
svn commit: r1430595 - in
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs: CHANGES.txt
dev-support/findbugsExcludeFile.xml
Author: eli
Date: Tue Jan 8 22:43:40 2013
New Revision: 1430595
URL: http://svn.apache.org/viewvc?rev=1430595&view=rev
Log:
HDFS-4035. LightWeightGSet and LightWeightHashSet increment a volatile without synchronization. Contributed by Eli Collins
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt?rev=1430595&r1=1430594&r2=1430595&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Tue Jan 8 22:43:40 2013
@@ -467,6 +467,9 @@ Release 2.0.3-alpha - Unreleased
HDFS-4034. Remove redundant null checks. (eli)
+ HDFS-4035. LightWeightGSet and LightWeightHashSet increment a
+ volatile without synchronization. (eli)
+
OPTIMIZATIONS
BUG FIXES
Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml?rev=1430595&r1=1430594&r2=1430595&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml (original)
+++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml Tue Jan 8 22:43:40 2013
@@ -308,4 +308,20 @@
<Field name="pendingReceivedRequests" />
<Bug pattern="VO_VOLATILE_INCREMENT" />
</Match>
+ <!-- The "LightWeight" classes are explicitly not thread safe -->
+ <Match>
+ <Class name="org.apache.hadoop.hdfs.util.LightWeightGSet" />
+ <Field name="modification" />
+ <Bug pattern="VO_VOLATILE_INCREMENT" />
+ </Match>
+ <Match>
+ <Class name="org.apache.hadoop.hdfs.util.LightWeightHashSet" />
+ <Field name="modification" />
+ <Bug pattern="VO_VOLATILE_INCREMENT" />
+ </Match>
+ <Match>
+ <Class name="org.apache.hadoop.hdfs.util.LightWeightLinkedSet" />
+ <Field name="modification" />
+ <Bug pattern="VO_VOLATILE_INCREMENT" />
+ </Match>
</FindBugsFilter>