[GitHub] dubee commented on a change in pull request #3991: Provide Artifact with File Storage Activation Store

[GitBox <gi...@apache.org>]

dubee commented on a change in pull request #3991: Provide Artifact with File Storage Activation Store
URL: https://github.com/apache/incubator-openwhisk/pull/3991#discussion_r247531650
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/database/ArtifactWithFileStorageActivationStore.scala
 ##########
 @@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.openwhisk.core.database
+
+import java.nio.file.Paths
+
+import akka.actor.ActorSystem
+import akka.stream._
+import org.apache.openwhisk.common.{Logging, TransactionId}
+import org.apache.openwhisk.core.ConfigKeys
+import org.apache.openwhisk.core.entity.{DocInfo, _}
+import pureconfig.loadConfigOrThrow
+import spray.json._
+
+import scala.concurrent.Future
+
+case class ArtifactWithFileStorageActivationStoreConfig(logFilePrefix: String,
+                                                        logPath: String,
+                                                        userIdField: String,
+                                                        writeToArtifact: Boolean,
+                                                        writeLogsToArtifact: Boolean,
+                                                        writeResultToArtifact: Boolean)
+
+class ArtifactWithFileStorageActivationStore(
+  actorSystem: ActorSystem,
+  actorMaterializer: ActorMaterializer,
+  logging: Logging,
+  config: ArtifactWithFileStorageActivationStoreConfig =
+    loadConfigOrThrow[ArtifactWithFileStorageActivationStoreConfig](ConfigKeys.activationStoreWithFileStorage))
+    extends ArtifactActivationStore(actorSystem, actorMaterializer, logging) {
+
+  private val activationFileStorage =
+    new ActivationFileStorage(config.logFilePrefix, Paths.get(config.logPath), actorMaterializer, logging)
+
+  def getLogFile = activationFileStorage.getLogFile
+
+  override def store(activation: WhiskActivation, context: UserContext)(
+    implicit transid: TransactionId,
+    notifier: Option[CacheChangeNotification]): Future[DocInfo] = {
+    val additionalFields = Map(config.userIdField -> context.user.namespace.uuid.toJson)
+
+    activationFileStorage.activationToFile(activation, context, additionalFields)
+
+    if (config.writeToArtifact) {
 
 Review comment:
   @cbickel, an on/off switch per namespace here would be fairly easy to implement.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services