You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (JIRA)" <ji...@apache.org> on 2014/10/01 21:23:34 UTC

[jira] [Resolved] (THRIFT-2689) struct names that differ only in capitalization of first character generate broken erlang code

     [ https://issues.apache.org/jira/browse/THRIFT-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer resolved THRIFT-2689.
--------------------------------
    Resolution: Fixed

Committed.

> struct names that differ only in capitalization of first character generate broken erlang code
> ----------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-2689
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2689
>             Project: Thrift
>          Issue Type: Bug
>          Components: Erlang - Compiler, Erlang - Library
>            Reporter: alisdair sullivan
>            Assignee: alisdair sullivan
>            Priority: Minor
>             Fix For: 0.9.2
>
>
> the following thrift specification generates broken erlang code:
> struct invalid { /* contents of struct are irrelevent */ }
> struct Invalid { /* still irrelevent }
> the compiler currently renames any struct that starts with a capital so that it starts with a lowercase letter. instead, it should leave names intact and use proper erlang syntax in generation. the attached patch does exactly that
> this does break backwards compatibility



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)