You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Richard S. Hall" <he...@ungoverned.org> on 2011/09/20 17:14:48 UTC

Re: svn commit: r1173181 - /felix/trunk/eventadmin/impl/pom.xml

On 9/20/11 11:10 AM, gnodet@apache.org wrote:
> Author: gnodet
> Date: Tue Sep 20 15:10:23 2011
> New Revision: 1173181
>
> URL: http://svn.apache.org/viewvc?rev=1173181&view=rev
> Log:
> FELIX-3121: add back service manifest headers
>
> Modified:
>      felix/trunk/eventadmin/impl/pom.xml
>
> Modified: felix/trunk/eventadmin/impl/pom.xml
> URL: http://svn.apache.org/viewvc/felix/trunk/eventadmin/impl/pom.xml?rev=1173181&r1=1173180&r2=1173181&view=diff
> ==============================================================================
> --- felix/trunk/eventadmin/impl/pom.xml (original)
> +++ felix/trunk/eventadmin/impl/pom.xml Tue Sep 20 15:10:23 2011
> @@ -98,6 +98,14 @@
>                           </Import-Package>
>                           <Export-Package>org.osgi.service.event</Export-Package>
>                           <Private-Package>org.apache.felix.eventadmin.impl.*</Private-Package>
> +<Import-Service>
> +                            org.osgi.service.event.EventHandler;availability:=optional;multiple:=true,
> +                            org.osgi.service.log.LogService;availability:=optional;multiple:=false,
> +                            org.osgi.service.log.LogReaderService;availability:=optional;multiple:=false

What is the 'availability' directive? Should that be 'resolution'?

-> richard

> +</Import-Service>
> +<Export-Service>
> +                            org.osgi.service.event.EventAdmin
> +</Export-Service>
>                           <!-- Include concurrent lib but not sub packages -->
>                           <Embed-Dependency>
>                               concurrent;inline="EDU/oswego/cs/dl/util/concurrent/[A-Z]*"
>
>

Re: svn commit: r1173181 - /felix/trunk/eventadmin/impl/pom.xml

Posted by Guillaume Nodet <gn...@gmail.com>.
It's related to the obr xml syntax which is using 'availability' ...  I just
reused the same so that the obr bindex does not need to do any translation.

On Tue, Sep 20, 2011 at 17:14, Richard S. Hall <he...@ungoverned.org> wrote:

> On 9/20/11 11:10 AM, gnodet@apache.org wrote:
>
>> Author: gnodet
>> Date: Tue Sep 20 15:10:23 2011
>> New Revision: 1173181
>>
>> URL: http://svn.apache.org/viewvc?**rev=1173181&view=rev<http://svn.apache.org/viewvc?rev=1173181&view=rev>
>> Log:
>> FELIX-3121: add back service manifest headers
>>
>> Modified:
>>     felix/trunk/eventadmin/impl/**pom.xml
>>
>> Modified: felix/trunk/eventadmin/impl/**pom.xml
>> URL: http://svn.apache.org/viewvc/**felix/trunk/eventadmin/impl/**
>> pom.xml?rev=1173181&r1=**1173180&r2=1173181&view=diff<http://svn.apache.org/viewvc/felix/trunk/eventadmin/impl/pom.xml?rev=1173181&r1=1173180&r2=1173181&view=diff>
>> ==============================**==============================**
>> ==================
>> --- felix/trunk/eventadmin/impl/**pom.xml (original)
>> +++ felix/trunk/eventadmin/impl/**pom.xml Tue Sep 20 15:10:23 2011
>> @@ -98,6 +98,14 @@
>>                          </Import-Package>
>>                          <Export-Package>org.osgi.**
>> service.event</Export-Package>
>>                          <Private-Package>org.apache.**
>> felix.eventadmin.impl.*</**Private-Package>
>> +<Import-Service>
>> +                            org.osgi.service.event.**
>> EventHandler;availability:=**optional;multiple:=true,
>> +                            org.osgi.service.log.**
>> LogService;availability:=**optional;multiple:=false,
>> +                            org.osgi.service.log.**
>> LogReaderService;availability:**=optional;multiple:=false
>>
>
> What is the 'availability' directive? Should that be 'resolution'?
>
> -> richard
>
>  +</Import-Service>
>>
>> +<Export-Service>
>> +                            org.osgi.service.event.**EventAdmin
>> +</Export-Service>
>>                          <!-- Include concurrent lib but not sub packages
>> -->
>>                          <Embed-Dependency>
>>                              concurrent;inline="EDU/oswego/**
>> cs/dl/util/concurrent/[A-Z]*"
>>
>>
>>


-- 
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com

Re: svn commit: r1173181 - /felix/trunk/eventadmin/impl/pom.xml

Posted by Arjun Panday <ar...@alcatel-lucent.com>.
sorry, i missed that part! thanks.

On 09/20/2011 06:25 PM, Guillaume Nodet wrote:
> As i said, the indexer code is in the bundlerepository project and there's
> an API and OSGi service to access it at runtime.
> I'm using it at runtime, not through maven usually.
>
> On Tue, Sep 20, 2011 at 18:19, Arjun Panday<arjun.panday@alcatel-lucent.com
>> wrote:
>> Thanks for the clarification.
>> But it means that the bundle is incompatible with the "official" indexer..
>> Moreover don't use maven to generate our OBR; is that indexer useable
>> oustide maven?
>> maven is a development tool, while the OBR is "deployment time" on a
>> production platform; it seems like two different worlds to me.
>>
>> -arjun
>>
>>
>>
>> On 09/20/2011 06:05 PM, Guillaume Nodet wrote:
>>
>>> I'm using the bindex code in the maven bundle plugin.
>>> The code is actually in obr at [1] and the optional directive has been
>>> fixed
>>> a while ago there.
>>>
>>> Fwiw, I usually don't use bindex and I always create the obr constraints
>>> on
>>> the fly programmatically using the interface at [2] and the
>>> createResource()
>>> methods.
>>>
>>> [1]
>>> http://svn.apache.org/repos/**asf/felix/trunk/**
>>> bundlerepository/src/main/**java/org/apache/felix/**
>>> bundlerepository/impl/**DataModelHelperImpl.java<http://svn.apache.org/repos/asf/felix/trunk/bundlerepository/src/main/java/org/apache/felix/bundlerepository/impl/DataModelHelperImpl.java>
>>> [2]
>>> http://svn.apache.org/viewvc/**felix/trunk/bundlerepository/**
>>> src/main/java/org/apache/**felix/bundlerepository/**
>>> DataModelHelper.java?view=**markup<http://svn.apache.org/viewvc/felix/trunk/bundlerepository/src/main/java/org/apache/felix/bundlerepository/DataModelHelper.java?view=markup>
>>>
>>>
>>>
>>> On Tue, Sep 20, 2011 at 17:24, Arjun Panday<arjun.panday@alcatel-**
>>> lucent.com<ar...@alcatel-lucent.com>
>>>
>>>> wrote:
>>>> Guillaume,
>>>>
>>>> which indexer are you using?
>>>> bindex-2.2 generates the requirements below and it breaks my OBR
>>>> resolution:
>>>>
>>>> <require extend='false' filter='(service=org.osgi.****
>>>> service.event.EventHandler)'
>>>> multiple='true' name='service' optional='false'>
>>>>
>>>>       Import Service org.osgi.service.event.****EventHandler
>>>> </require>
>>>> <require extend='false' filter='(service=org.osgi.****
>>>> service.log.LogService)'
>>>> multiple='true' name='service' optional='false'>
>>>>       Import Service org.osgi.service.log.****LogService
>>>> </require>
>>>> <require extend='false' filter='(service=org.osgi.****
>>>> service.log.LogReaderService)'
>>>> multiple='true' name='service' optional='false'>
>>>>       Import Service org.osgi.service.log.****LogReaderService
>>>> </require>
>>>>
>>>> /arjun
>>>>
>>>>
>>>>
>>>>
>>>> On 09/20/2011 05:14 PM, Richard S. Hall wrote:
>>>>
>>>>   On 9/20/11 11:10 AM, gnodet@apache.org wrote:
>>>>>   Author: gnodet
>>>>>> Date: Tue Sep 20 15:10:23 2011
>>>>>> New Revision: 1173181
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?****rev=1173181&view=rev<http://svn.apache.org/viewvc?**rev=1173181&view=rev>
>>>>>> <http://**svn.apache.org/viewvc?rev=**1173181&view=rev<http://svn.apache.org/viewvc?rev=1173181&view=rev>
>>>>>> Log:
>>>>>> FELIX-3121: add back service manifest headers
>>>>>>
>>>>>> Modified:
>>>>>>       felix/trunk/eventadmin/impl/****pom.xml
>>>>>>
>>>>>> Modified: felix/trunk/eventadmin/impl/****pom.xml
>>>>>> URL: http://svn.apache.org/viewvc/****felix/trunk/eventadmin/impl/****<http://svn.apache.org/viewvc/**felix/trunk/eventadmin/impl/**>
>>>>>> pom.xml?rev=1173181&r1=****1173180&r2=1173181&view=diff<h**
>>>>>> ttp://svn.apache.org/viewvc/**felix/trunk/eventadmin/impl/**
>>>>>> pom.xml?rev=1173181&r1=**1173180&r2=1173181&view=diff<http://svn.apache.org/viewvc/felix/trunk/eventadmin/impl/pom.xml?rev=1173181&r1=1173180&r2=1173181&view=diff>
>>>>>> ==============================****============================**==**
>>>>>> ==================
>>>>>> --- felix/trunk/eventadmin/impl/****pom.xml (original)
>>>>>> +++ felix/trunk/eventadmin/impl/****pom.xml Tue Sep 20 15:10:23 2011
>>>>>> @@ -98,6 +98,14 @@
>>>>>>                            </Import-Package>
>>>>>>                            <Export-Package>org.osgi.**
>>>>>> service.event</Export-Package>
>>>>>>                            <Private-Package>org.apache.**
>>>>>> felix.eventadmin.impl.*</****Private-Package>
>>>>>> +<Import-Service>
>>>>>> +                            org.osgi.service.event.**
>>>>>> EventHandler;availability:=****optional;multiple:=true,
>>>>>> +                            org.osgi.service.log.**
>>>>>> LogService;availability:=****optional;multiple:=false,
>>>>>> +                            org.osgi.service.log.**
>>>>>> LogReaderService;availability:****=optional;multiple:=false
>>>>>>
>>>>>>   What is the 'availability' directive? Should that be 'resolution'?
>>>>> ->    richard
>>>>>
>>>>>   +</Import-Service>
>>>>>
>>>>>> +<Export-Service>
>>>>>> +                            org.osgi.service.event.****EventAdmin
>>>>>> +</Export-Service>
>>>>>>                            <!-- Include concurrent lib but not sub
>>>>>> packages -->
>>>>>>                            <Embed-Dependency>
>>>>>>                                concurrent;inline="EDU/oswego/****
>>>>>> cs/dl/util/concurrent/[A-Z]*"
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>


Re: svn commit: r1173181 - /felix/trunk/eventadmin/impl/pom.xml

Posted by Guillaume Nodet <gn...@gmail.com>.
As i said, the indexer code is in the bundlerepository project and there's
an API and OSGi service to access it at runtime.
I'm using it at runtime, not through maven usually.

On Tue, Sep 20, 2011 at 18:19, Arjun Panday <arjun.panday@alcatel-lucent.com
> wrote:

> Thanks for the clarification.
> But it means that the bundle is incompatible with the "official" indexer..
> Moreover don't use maven to generate our OBR; is that indexer useable
> oustide maven?
> maven is a development tool, while the OBR is "deployment time" on a
> production platform; it seems like two different worlds to me.
>
> -arjun
>
>
>
> On 09/20/2011 06:05 PM, Guillaume Nodet wrote:
>
>> I'm using the bindex code in the maven bundle plugin.
>> The code is actually in obr at [1] and the optional directive has been
>> fixed
>> a while ago there.
>>
>> Fwiw, I usually don't use bindex and I always create the obr constraints
>> on
>> the fly programmatically using the interface at [2] and the
>> createResource()
>> methods.
>>
>> [1]
>> http://svn.apache.org/repos/**asf/felix/trunk/**
>> bundlerepository/src/main/**java/org/apache/felix/**
>> bundlerepository/impl/**DataModelHelperImpl.java<http://svn.apache.org/repos/asf/felix/trunk/bundlerepository/src/main/java/org/apache/felix/bundlerepository/impl/DataModelHelperImpl.java>
>> [2]
>> http://svn.apache.org/viewvc/**felix/trunk/bundlerepository/**
>> src/main/java/org/apache/**felix/bundlerepository/**
>> DataModelHelper.java?view=**markup<http://svn.apache.org/viewvc/felix/trunk/bundlerepository/src/main/java/org/apache/felix/bundlerepository/DataModelHelper.java?view=markup>
>>
>>
>>
>> On Tue, Sep 20, 2011 at 17:24, Arjun Panday<arjun.panday@alcatel-**
>> lucent.com <ar...@alcatel-lucent.com>
>>
>>> wrote:
>>> Guillaume,
>>>
>>> which indexer are you using?
>>> bindex-2.2 generates the requirements below and it breaks my OBR
>>> resolution:
>>>
>>> <require extend='false' filter='(service=org.osgi.****
>>> service.event.EventHandler)'
>>> multiple='true' name='service' optional='false'>
>>>
>>>      Import Service org.osgi.service.event.****EventHandler
>>> </require>
>>> <require extend='false' filter='(service=org.osgi.****
>>> service.log.LogService)'
>>> multiple='true' name='service' optional='false'>
>>>      Import Service org.osgi.service.log.****LogService
>>> </require>
>>> <require extend='false' filter='(service=org.osgi.****
>>> service.log.LogReaderService)'
>>> multiple='true' name='service' optional='false'>
>>>      Import Service org.osgi.service.log.****LogReaderService
>>> </require>
>>>
>>> /arjun
>>>
>>>
>>>
>>>
>>> On 09/20/2011 05:14 PM, Richard S. Hall wrote:
>>>
>>>  On 9/20/11 11:10 AM, gnodet@apache.org wrote:
>>>>
>>>>  Author: gnodet
>>>>> Date: Tue Sep 20 15:10:23 2011
>>>>> New Revision: 1173181
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?****rev=1173181&view=rev<http://svn.apache.org/viewvc?**rev=1173181&view=rev>
>>>>> <http://**svn.apache.org/viewvc?rev=**1173181&view=rev<http://svn.apache.org/viewvc?rev=1173181&view=rev>
>>>>> >
>>>>>
>>>>> Log:
>>>>> FELIX-3121: add back service manifest headers
>>>>>
>>>>> Modified:
>>>>>      felix/trunk/eventadmin/impl/****pom.xml
>>>>>
>>>>> Modified: felix/trunk/eventadmin/impl/****pom.xml
>>>>> URL: http://svn.apache.org/viewvc/****felix/trunk/eventadmin/impl/****<http://svn.apache.org/viewvc/**felix/trunk/eventadmin/impl/**>
>>>>> pom.xml?rev=1173181&r1=****1173180&r2=1173181&view=diff<h**
>>>>> ttp://svn.apache.org/viewvc/**felix/trunk/eventadmin/impl/**
>>>>> pom.xml?rev=1173181&r1=**1173180&r2=1173181&view=diff<http://svn.apache.org/viewvc/felix/trunk/eventadmin/impl/pom.xml?rev=1173181&r1=1173180&r2=1173181&view=diff>
>>>>> >
>>>>>
>>>>> ==============================****============================**==**
>>>>> ==================
>>>>> --- felix/trunk/eventadmin/impl/****pom.xml (original)
>>>>> +++ felix/trunk/eventadmin/impl/****pom.xml Tue Sep 20 15:10:23 2011
>>>>> @@ -98,6 +98,14 @@
>>>>>                           </Import-Package>
>>>>>                           <Export-Package>org.osgi.**
>>>>> service.event</Export-Package>
>>>>>                           <Private-Package>org.apache.**
>>>>> felix.eventadmin.impl.*</****Private-Package>
>>>>> +<Import-Service>
>>>>> +                            org.osgi.service.event.**
>>>>> EventHandler;availability:=****optional;multiple:=true,
>>>>> +                            org.osgi.service.log.**
>>>>> LogService;availability:=****optional;multiple:=false,
>>>>> +                            org.osgi.service.log.**
>>>>> LogReaderService;availability:****=optional;multiple:=false
>>>>>
>>>>>  What is the 'availability' directive? Should that be 'resolution'?
>>>>
>>>> ->   richard
>>>>
>>>>  +</Import-Service>
>>>>
>>>>> +<Export-Service>
>>>>> +                            org.osgi.service.event.****EventAdmin
>>>>> +</Export-Service>
>>>>>                           <!-- Include concurrent lib but not sub
>>>>> packages -->
>>>>>                           <Embed-Dependency>
>>>>>                               concurrent;inline="EDU/oswego/****
>>>>> cs/dl/util/concurrent/[A-Z]*"
>>>>>
>>>>>
>>>>>
>>>>>
>>
>


-- 
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com

Re: svn commit: r1173181 - /felix/trunk/eventadmin/impl/pom.xml

Posted by Arjun Panday <ar...@alcatel-lucent.com>.
Thanks for the clarification.
But it means that the bundle is incompatible with the "official" indexer..
Moreover don't use maven to generate our OBR; is that indexer useable 
oustide maven?
maven is a development tool, while the OBR is "deployment time" on a 
production platform; it seems like two different worlds to me.

-arjun


On 09/20/2011 06:05 PM, Guillaume Nodet wrote:
> I'm using the bindex code in the maven bundle plugin.
> The code is actually in obr at [1] and the optional directive has been fixed
> a while ago there.
>
> Fwiw, I usually don't use bindex and I always create the obr constraints on
> the fly programmatically using the interface at [2] and the createResource()
> methods.
>
> [1]
> http://svn.apache.org/repos/asf/felix/trunk/bundlerepository/src/main/java/org/apache/felix/bundlerepository/impl/DataModelHelperImpl.java
> [2]
> http://svn.apache.org/viewvc/felix/trunk/bundlerepository/src/main/java/org/apache/felix/bundlerepository/DataModelHelper.java?view=markup
>
>
>
> On Tue, Sep 20, 2011 at 17:24, Arjun Panday<arjun.panday@alcatel-lucent.com
>> wrote:
>> Guillaume,
>>
>> which indexer are you using?
>> bindex-2.2 generates the requirements below and it breaks my OBR
>> resolution:
>>
>> <require extend='false' filter='(service=org.osgi.**service.event.EventHandler)'
>> multiple='true' name='service' optional='false'>
>>
>>       Import Service org.osgi.service.event.**EventHandler
>> </require>
>> <require extend='false' filter='(service=org.osgi.**service.log.LogService)'
>> multiple='true' name='service' optional='false'>
>>       Import Service org.osgi.service.log.**LogService
>> </require>
>> <require extend='false' filter='(service=org.osgi.**service.log.LogReaderService)'
>> multiple='true' name='service' optional='false'>
>>       Import Service org.osgi.service.log.**LogReaderService
>> </require>
>>
>> /arjun
>>
>>
>>
>>
>> On 09/20/2011 05:14 PM, Richard S. Hall wrote:
>>
>>> On 9/20/11 11:10 AM, gnodet@apache.org wrote:
>>>
>>>> Author: gnodet
>>>> Date: Tue Sep 20 15:10:23 2011
>>>> New Revision: 1173181
>>>>
>>>> URL: http://svn.apache.org/viewvc?**rev=1173181&view=rev<http://svn.apache.org/viewvc?rev=1173181&view=rev>
>>>> Log:
>>>> FELIX-3121: add back service manifest headers
>>>>
>>>> Modified:
>>>>       felix/trunk/eventadmin/impl/**pom.xml
>>>>
>>>> Modified: felix/trunk/eventadmin/impl/**pom.xml
>>>> URL: http://svn.apache.org/viewvc/**felix/trunk/eventadmin/impl/**
>>>> pom.xml?rev=1173181&r1=**1173180&r2=1173181&view=diff<http://svn.apache.org/viewvc/felix/trunk/eventadmin/impl/pom.xml?rev=1173181&r1=1173180&r2=1173181&view=diff>
>>>> ==============================**==============================**
>>>> ==================
>>>> --- felix/trunk/eventadmin/impl/**pom.xml (original)
>>>> +++ felix/trunk/eventadmin/impl/**pom.xml Tue Sep 20 15:10:23 2011
>>>> @@ -98,6 +98,14 @@
>>>>                            </Import-Package>
>>>>                            <Export-Package>org.osgi.**
>>>> service.event</Export-Package>
>>>>                            <Private-Package>org.apache.**
>>>> felix.eventadmin.impl.*</**Private-Package>
>>>> +<Import-Service>
>>>> +                            org.osgi.service.event.**
>>>> EventHandler;availability:=**optional;multiple:=true,
>>>> +                            org.osgi.service.log.**
>>>> LogService;availability:=**optional;multiple:=false,
>>>> +                            org.osgi.service.log.**
>>>> LogReaderService;availability:**=optional;multiple:=false
>>>>
>>> What is the 'availability' directive? Should that be 'resolution'?
>>>
>>> ->   richard
>>>
>>>   +</Import-Service>
>>>> +<Export-Service>
>>>> +                            org.osgi.service.event.**EventAdmin
>>>> +</Export-Service>
>>>>                            <!-- Include concurrent lib but not sub
>>>> packages -->
>>>>                            <Embed-Dependency>
>>>>                                concurrent;inline="EDU/oswego/**
>>>> cs/dl/util/concurrent/[A-Z]*"
>>>>
>>>>
>>>>
>


Re: svn commit: r1173181 - /felix/trunk/eventadmin/impl/pom.xml

Posted by Guillaume Nodet <gn...@gmail.com>.
Btw, you can find the output by looking at your
~/.m2/repository/repository.xml
The same code is used to generate that one while building the bundle.

On Tue, Sep 20, 2011 at 18:05, Guillaume Nodet <gn...@gmail.com> wrote:

> I'm using the bindex code in the maven bundle plugin.
> The code is actually in obr at [1] and the optional directive has been
> fixed a while ago there.
>
> Fwiw, I usually don't use bindex and I always create the obr constraints on
> the fly programmatically using the interface at [2] and the createResource()
> methods.
>
> [1]
> http://svn.apache.org/repos/asf/felix/trunk/bundlerepository/src/main/java/org/apache/felix/bundlerepository/impl/DataModelHelperImpl.java
> [2]
> http://svn.apache.org/viewvc/felix/trunk/bundlerepository/src/main/java/org/apache/felix/bundlerepository/DataModelHelper.java?view=markup
>
>
>
> On Tue, Sep 20, 2011 at 17:24, Arjun Panday <
> arjun.panday@alcatel-lucent.com> wrote:
>
>> Guillaume,
>>
>> which indexer are you using?
>> bindex-2.2 generates the requirements below and it breaks my OBR
>> resolution:
>>
>> <require extend='false' filter='(service=org.osgi.**service.event.EventHandler)'
>> multiple='true' name='service' optional='false'>
>>
>>      Import Service org.osgi.service.event.**EventHandler
>> </require>
>> <require extend='false' filter='(service=org.osgi.**service.log.LogService)'
>> multiple='true' name='service' optional='false'>
>>      Import Service org.osgi.service.log.**LogService
>> </require>
>> <require extend='false' filter='(service=org.osgi.**service.log.LogReaderService)'
>> multiple='true' name='service' optional='false'>
>>      Import Service org.osgi.service.log.**LogReaderService
>> </require>
>>
>> /arjun
>>
>>
>>
>>
>> On 09/20/2011 05:14 PM, Richard S. Hall wrote:
>>
>>> On 9/20/11 11:10 AM, gnodet@apache.org wrote:
>>>
>>>> Author: gnodet
>>>> Date: Tue Sep 20 15:10:23 2011
>>>> New Revision: 1173181
>>>>
>>>> URL: http://svn.apache.org/viewvc?**rev=1173181&view=rev<http://svn.apache.org/viewvc?rev=1173181&view=rev>
>>>> Log:
>>>> FELIX-3121: add back service manifest headers
>>>>
>>>> Modified:
>>>>      felix/trunk/eventadmin/impl/**pom.xml
>>>>
>>>> Modified: felix/trunk/eventadmin/impl/**pom.xml
>>>> URL: http://svn.apache.org/viewvc/**felix/trunk/eventadmin/impl/**
>>>> pom.xml?rev=1173181&r1=**1173180&r2=1173181&view=diff<http://svn.apache.org/viewvc/felix/trunk/eventadmin/impl/pom.xml?rev=1173181&r1=1173180&r2=1173181&view=diff>
>>>> ==============================**==============================**
>>>> ==================
>>>> --- felix/trunk/eventadmin/impl/**pom.xml (original)
>>>> +++ felix/trunk/eventadmin/impl/**pom.xml Tue Sep 20 15:10:23 2011
>>>> @@ -98,6 +98,14 @@
>>>>                           </Import-Package>
>>>>                           <Export-Package>org.osgi.**
>>>> service.event</Export-Package>
>>>>                           <Private-Package>org.apache.**
>>>> felix.eventadmin.impl.*</**Private-Package>
>>>> +<Import-Service>
>>>> +                            org.osgi.service.event.**
>>>> EventHandler;availability:=**optional;multiple:=true,
>>>> +                            org.osgi.service.log.**
>>>> LogService;availability:=**optional;multiple:=false,
>>>> +                            org.osgi.service.log.**
>>>> LogReaderService;availability:**=optional;multiple:=false
>>>>
>>> What is the 'availability' directive? Should that be 'resolution'?
>>>
>>> ->  richard
>>>
>>>  +</Import-Service>
>>>> +<Export-Service>
>>>> +                            org.osgi.service.event.**EventAdmin
>>>> +</Export-Service>
>>>>                           <!-- Include concurrent lib but not sub
>>>> packages -->
>>>>                           <Embed-Dependency>
>>>>                               concurrent;inline="EDU/oswego/**
>>>> cs/dl/util/concurrent/[A-Z]*"
>>>>
>>>>
>>>>
>>
>
>
> --
> ------------------------
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
> ------------------------
> Open Source SOA
> http://fusesource.com
>
>


-- 
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com

Re: svn commit: r1173181 - /felix/trunk/eventadmin/impl/pom.xml

Posted by Guillaume Nodet <gn...@gmail.com>.
I'm using the bindex code in the maven bundle plugin.
The code is actually in obr at [1] and the optional directive has been fixed
a while ago there.

Fwiw, I usually don't use bindex and I always create the obr constraints on
the fly programmatically using the interface at [2] and the createResource()
methods.

[1]
http://svn.apache.org/repos/asf/felix/trunk/bundlerepository/src/main/java/org/apache/felix/bundlerepository/impl/DataModelHelperImpl.java
[2]
http://svn.apache.org/viewvc/felix/trunk/bundlerepository/src/main/java/org/apache/felix/bundlerepository/DataModelHelper.java?view=markup



On Tue, Sep 20, 2011 at 17:24, Arjun Panday <arjun.panday@alcatel-lucent.com
> wrote:

> Guillaume,
>
> which indexer are you using?
> bindex-2.2 generates the requirements below and it breaks my OBR
> resolution:
>
> <require extend='false' filter='(service=org.osgi.**service.event.EventHandler)'
> multiple='true' name='service' optional='false'>
>
>      Import Service org.osgi.service.event.**EventHandler
> </require>
> <require extend='false' filter='(service=org.osgi.**service.log.LogService)'
> multiple='true' name='service' optional='false'>
>      Import Service org.osgi.service.log.**LogService
> </require>
> <require extend='false' filter='(service=org.osgi.**service.log.LogReaderService)'
> multiple='true' name='service' optional='false'>
>      Import Service org.osgi.service.log.**LogReaderService
> </require>
>
> /arjun
>
>
>
>
> On 09/20/2011 05:14 PM, Richard S. Hall wrote:
>
>> On 9/20/11 11:10 AM, gnodet@apache.org wrote:
>>
>>> Author: gnodet
>>> Date: Tue Sep 20 15:10:23 2011
>>> New Revision: 1173181
>>>
>>> URL: http://svn.apache.org/viewvc?**rev=1173181&view=rev<http://svn.apache.org/viewvc?rev=1173181&view=rev>
>>> Log:
>>> FELIX-3121: add back service manifest headers
>>>
>>> Modified:
>>>      felix/trunk/eventadmin/impl/**pom.xml
>>>
>>> Modified: felix/trunk/eventadmin/impl/**pom.xml
>>> URL: http://svn.apache.org/viewvc/**felix/trunk/eventadmin/impl/**
>>> pom.xml?rev=1173181&r1=**1173180&r2=1173181&view=diff<http://svn.apache.org/viewvc/felix/trunk/eventadmin/impl/pom.xml?rev=1173181&r1=1173180&r2=1173181&view=diff>
>>> ==============================**==============================**
>>> ==================
>>> --- felix/trunk/eventadmin/impl/**pom.xml (original)
>>> +++ felix/trunk/eventadmin/impl/**pom.xml Tue Sep 20 15:10:23 2011
>>> @@ -98,6 +98,14 @@
>>>                           </Import-Package>
>>>                           <Export-Package>org.osgi.**
>>> service.event</Export-Package>
>>>                           <Private-Package>org.apache.**
>>> felix.eventadmin.impl.*</**Private-Package>
>>> +<Import-Service>
>>> +                            org.osgi.service.event.**
>>> EventHandler;availability:=**optional;multiple:=true,
>>> +                            org.osgi.service.log.**
>>> LogService;availability:=**optional;multiple:=false,
>>> +                            org.osgi.service.log.**
>>> LogReaderService;availability:**=optional;multiple:=false
>>>
>> What is the 'availability' directive? Should that be 'resolution'?
>>
>> ->  richard
>>
>>  +</Import-Service>
>>> +<Export-Service>
>>> +                            org.osgi.service.event.**EventAdmin
>>> +</Export-Service>
>>>                           <!-- Include concurrent lib but not sub
>>> packages -->
>>>                           <Embed-Dependency>
>>>                               concurrent;inline="EDU/oswego/**
>>> cs/dl/util/concurrent/[A-Z]*"
>>>
>>>
>>>
>


-- 
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com

Re: svn commit: r1173181 - /felix/trunk/eventadmin/impl/pom.xml

Posted by Arjun Panday <ar...@alcatel-lucent.com>.
Guillaume,

which indexer are you using?
bindex-2.2 generates the requirements below and it breaks my OBR resolution:

<require extend='false' 
filter='(service=org.osgi.service.event.EventHandler)' multiple='true' 
name='service' optional='false'>
       Import Service org.osgi.service.event.EventHandler
</require>
<require extend='false' 
filter='(service=org.osgi.service.log.LogService)' multiple='true' 
name='service' optional='false'>
       Import Service org.osgi.service.log.LogService
</require>
<require extend='false' 
filter='(service=org.osgi.service.log.LogReaderService)' multiple='true' 
name='service' optional='false'>
       Import Service org.osgi.service.log.LogReaderService
</require>

/arjun



On 09/20/2011 05:14 PM, Richard S. Hall wrote:
> On 9/20/11 11:10 AM, gnodet@apache.org wrote:
>> Author: gnodet
>> Date: Tue Sep 20 15:10:23 2011
>> New Revision: 1173181
>>
>> URL: http://svn.apache.org/viewvc?rev=1173181&view=rev
>> Log:
>> FELIX-3121: add back service manifest headers
>>
>> Modified:
>>       felix/trunk/eventadmin/impl/pom.xml
>>
>> Modified: felix/trunk/eventadmin/impl/pom.xml
>> URL: http://svn.apache.org/viewvc/felix/trunk/eventadmin/impl/pom.xml?rev=1173181&r1=1173180&r2=1173181&view=diff
>> ==============================================================================
>> --- felix/trunk/eventadmin/impl/pom.xml (original)
>> +++ felix/trunk/eventadmin/impl/pom.xml Tue Sep 20 15:10:23 2011
>> @@ -98,6 +98,14 @@
>>                            </Import-Package>
>>                            <Export-Package>org.osgi.service.event</Export-Package>
>>                            <Private-Package>org.apache.felix.eventadmin.impl.*</Private-Package>
>> +<Import-Service>
>> +                            org.osgi.service.event.EventHandler;availability:=optional;multiple:=true,
>> +                            org.osgi.service.log.LogService;availability:=optional;multiple:=false,
>> +                            org.osgi.service.log.LogReaderService;availability:=optional;multiple:=false
> What is the 'availability' directive? Should that be 'resolution'?
>
> ->  richard
>
>> +</Import-Service>
>> +<Export-Service>
>> +                            org.osgi.service.event.EventAdmin
>> +</Export-Service>
>>                            <!-- Include concurrent lib but not sub packages -->
>>                            <Embed-Dependency>
>>                                concurrent;inline="EDU/oswego/cs/dl/util/concurrent/[A-Z]*"
>>
>>