You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by manuzhang <gi...@git.apache.org> on 2016/12/19 10:33:19 UTC
[GitHub] incubator-gearpump pull request #124: [GEARPUMP-255] Return application id w...
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/124
[GEARPUMP-255] Return application id when submitting application in J\u2026
\u2026ava DSL
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit message is formatted like:
`[GEARPUMP-<Jira issue #>] Meaningful description of pull request`
- [ ] Make sure tests pass via `sbt clean test`.
- [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/incubator-gearpump GEARPUMP-255
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/124.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #124
----
commit 29e930811e1b4b724765f32c4a73549fdc1fb882
Author: manuzhang <ow...@gmail.com>
Date: 2016-12-19T10:31:05Z
[GEARPUMP-255] Return application id when submitting application in Java DSL
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #124: [GEARPUMP-255] Return application id w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #124: [GEARPUMP-255] Return application id when sub...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/124
@huafengw please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #124: [GEARPUMP-255] Return application id when sub...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/124
## [Current coverage](https://codecov.io/gh/apache/incubator-gearpump/pull/124?src=pr) is 70.55% (diff: 100%)
> Merging [#124](https://codecov.io/gh/apache/incubator-gearpump/pull/124?src=pr) into [master](https://codecov.io/gh/apache/incubator-gearpump/branch/master?src=pr) will increase coverage by **0.20%**
```diff
@@ master #124 diff @@
==========================================
Files 186 186
Lines 5985 5985
Methods 5476 5471 -5
Messages 0 0
Branches 507 512 +5
==========================================
+ Hits 4211 4223 +12
+ Misses 1774 1762 -12
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [1bf6a9b...29e9308](https://codecov.io/gh/apache/incubator-gearpump/compare/1bf6a9ba8fa774b985fcd90a5d6bef129a4fb9a5...29e930811e1b4b724765f32c4a73549fdc1fb882?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #124: [GEARPUMP-255] Return application id when sub...
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/124
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---