You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/02 11:59:34 UTC
[GitHub] [incubator-seatunnel] zhaomin1423 opened a new issue #1373: [Feature][spark-connector-doris] refactor doris sink
zhaomin1423 opened a new issue #1373:
URL: https://github.com/apache/incubator-seatunnel/issues/1373
### Search before asking
- [X] I had searched in the [feature](https://github.com/apache/incubator-seatunnel/issues?q=is%3Aissue+label%3A%22Feature%22) and found no similar feature requirement.
### Description
refactor doris sink.
### Usage Scenario
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhaomin1423 commented on issue #1373: [Feature][spark-connector-doris] refactor doris sink
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on issue #1373:
URL: https://github.com/apache/incubator-seatunnel/issues/1373#issuecomment-1056939516
Hi, @CalvinKirs The flink connector doris and spark connector doris have common logical for writing data to doris. Whether we can have a common module responsible for reading and writing, then using it in connectors. What is your opinion？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on issue #1373: [Feature][spark-connector-doris] refactor doris sink
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on issue #1373:
URL: https://github.com/apache/incubator-seatunnel/issues/1373#issuecomment-1056964387
> Also, can we implement the connector alone and use the connector in the code. For example, in spark, using connector by read.format. In this way, our connectors can be used by everyone.
@RickyHuo @kid-xiong @wuchunfu hi, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhaomin1423 commented on issue #1373: [Feature][spark-connector-doris] refactor doris sink
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on issue #1373:
URL: https://github.com/apache/incubator-seatunnel/issues/1373#issuecomment-1056955804
Also, can we implement the connector alone and use the connector in the code. For example, in spark, using connector by read.format. In this way, our connectors can be used by everyone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhaomin1423 commented on issue #1373: [Feature][spark-connector-doris] refactor doris sink
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on issue #1373:
URL: https://github.com/apache/incubator-seatunnel/issues/1373#issuecomment-1056952096
> > Hi, @CalvinKirs The flink connector doris and spark connector doris have common logical for writing data to doris. Whether we can have a common module responsible for reading and writing, then using it in connectors. What is your opinion？
>
> One version is in Scala (Spark) and one version is in Java (Flink). I'm not sure if we can do it, do you have any good ideas?
Using java in scala is very natural. In fact, our team does the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on issue #1373: [Feature][spark-connector-doris] refactor doris sink
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on issue #1373:
URL: https://github.com/apache/incubator-seatunnel/issues/1373#issuecomment-1058839479
@xtr1993 It looks good, but will this increase the coupling between spark and flink?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] xtr1993 commented on issue #1373: [Feature][spark-connector-doris] refactor doris sink
Posted by GitBox <gi...@apache.org>.
xtr1993 commented on issue #1373:
URL: https://github.com/apache/incubator-seatunnel/issues/1373#issuecomment-1057635827
The community advocates the use of Java,In fact, calling java with scala is not standardized，It is better to use java refactoring directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on issue #1373: [Feature][spark-connector-doris] refactor doris sink
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on issue #1373:
URL: https://github.com/apache/incubator-seatunnel/issues/1373#issuecomment-1056947920
> Hi, @CalvinKirs The flink connector doris and spark connector doris have common logical for writing data to doris. Whether we can have a common module responsible for reading and writing, then using it in connectors. What is your opinion？
One version is in Scala (Spark) and one version is in Java (Flink). I'm not sure if we can do it, do you have any good ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on issue #1373: [Feature][spark-connector-doris] refactor doris sink
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on issue #1373:
URL: https://github.com/apache/incubator-seatunnel/issues/1373#issuecomment-1056963811
> > > Hi, @CalvinKirs The flink connector doris and spark connector doris have common logical for writing data to doris. Whether we can have a common module responsible for reading and writing, then using it in connectors. What is your opinion？
> >
> >
> > One version is in Scala (Spark) and one version is in Java (Flink). I'm not sure if we can do it, do you have any good ideas?
>
> Using java in scala is very natural. In fact, our team does the same.
I'm not familiar with Scala.... it would be better if this could be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org