[GitHub] [nifi] dan-s1 commented on a diff in pull request #6775: [NIFI-10877] Conversion of nifi-framework-core tests from Junit4 to J…

[GitBox <gi...@apache.org>]

dan-s1 commented on code in PR #6775:
URL: https://github.com/apache/nifi/pull/6775#discussion_r1046356567


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/repository/crypto/EncryptedFileSystemRepositoryTest.groovy:
##########
@@ -64,9 +61,9 @@ class EncryptedFileSystemRepositoryTest {
             (NiFiProperties.CONTENT_REPOSITORY_ENCRYPTION_KEY_PROVIDER_LOCATION)            : ""
     ]
 
-    @BeforeClass
+    @BeforeAll
     static void setUpOnce() throws Exception {
-        Assume.assumeTrue("Test only runs on *nix", !SystemUtils.IS_OS_WINDOWS)
+        Assumptions.assumeTrue(!SystemUtils.IS_OS_WINDOWS, "Test only runs on *nix")

Review Comment:
   @exceptionfactory I made the changes to this class and TestFileSystemRepository. I noticed that EncryptedSequentialAccessWriteAheadLogTest has this also but it has not been converted over to Junit 5. Do you mind if make the changes for JUnit 5 on this class also?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org