You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "kgusakov (via GitHub)" <gi...@apache.org> on 2023/06/08 21:33:04 UTC
[GitHub] [ignite-3] kgusakov opened a new pull request, #2171: IGNITE-19600 Removed topologyVersionedDataNodes
kgusakov opened a new pull request, #2171:
URL: https://github.com/apache/ignite-3/pull/2171
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] kgusakov commented on a diff in pull request #2171: IGNITE-19600 Removed topologyVersionedDataNodes
Posted by "kgusakov (via GitHub)" <gi...@apache.org>.
kgusakov commented on code in PR #2171:
URL: https://github.com/apache/ignite-3/pull/2171#discussion_r1228023852
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerLogicalTopologyEventsTest.java:
##########
@@ -45,6 +48,9 @@ void testMetaStorageKeysInitializedOnStartWhenTopVerEmpty() throws Exception {
distributionZoneManager.start();
+ verify(keyValueStorage, timeout(1000).times(1))
Review Comment:
It was here before the topologyVersioneDataNodes logic https://github.com/apache/ignite-3/pull/1729/files#diff-eee737dc0330b6a383f01df9ee1d1ae3135655204bdb1a261ff874674d4a6a78L190 - I just thought, that the author of this test earlier wanted to check that the call of keyValueStorage occuried during init.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] kgusakov commented on a diff in pull request #2171: IGNITE-19600 Removed topologyVersionedDataNodes
Posted by "kgusakov (via GitHub)" <gi...@apache.org>.
kgusakov commented on code in PR #2171:
URL: https://github.com/apache/ignite-3/pull/2171#discussion_r1228028031
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerLogicalTopologyEventsTest.java:
##########
@@ -45,6 +48,9 @@ void testMetaStorageKeysInitializedOnStartWhenTopVerEmpty() throws Exception {
distributionZoneManager.start();
+ verify(keyValueStorage, timeout(1000).times(1))
Review Comment:
Sorry, wrong test, I think I put it here by mistake, will remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sk0x50 merged pull request #2171: IGNITE-19600 Removed topologyVersionedDataNodes
Posted by "sk0x50 (via GitHub)" <gi...@apache.org>.
sk0x50 merged PR #2171:
URL: https://github.com/apache/ignite-3/pull/2171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] alievmirza commented on a diff in pull request #2171: IGNITE-19600 Removed topologyVersionedDataNodes
Posted by "alievmirza (via GitHub)" <gi...@apache.org>.
alievmirza commented on code in PR #2171:
URL: https://github.com/apache/ignite-3/pull/2171#discussion_r1227592992
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerLogicalTopologyEventsTest.java:
##########
@@ -45,6 +48,9 @@ void testMetaStorageKeysInitializedOnStartWhenTopVerEmpty() throws Exception {
distributionZoneManager.start();
+ verify(keyValueStorage, timeout(1000).times(1))
Review Comment:
why do we need changed in this class?
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerLogicalTopologyEventsTest.java:
##########
@@ -45,6 +48,9 @@ void testMetaStorageKeysInitializedOnStartWhenTopVerEmpty() throws Exception {
distributionZoneManager.start();
+ verify(keyValueStorage, timeout(1000).times(1))
Review Comment:
why do we need changes in this class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org