[PR] chore: enable `unreachable_pub` lint at workspace level [datafusion]

["rluvaton (via GitHub)" <gi...@apache.org>]

rluvaton opened a new pull request, #22153:
URL: https://github.com/apache/datafusion/pull/22153

   ## Which issue does this PR close?
   
   - Closes #.
   
   ## Rationale for this change
   
   The `unreachable_pub` rustc lint flags items declared `pub` whose effective visibility is narrower (because of an enclosing `pub(crate)` or private module). When that happens, the source reads as public API, but the item isn't actually reachable from outside the crate — misleading when auditing the public surface.
   
   Example currently in the tree: `InProgressSpillFile` and `SpillManager::create_in_progress_file` are marked `pub`, but they live behind `pub(crate) mod in_progress_spill_file;` / `pub(crate) mod spill_manager;` in `datafusion/physical-plan/src/spill/mod.rs`, so their effective visibility is `pub(crate)`.
   
   Turning the lint on workspace-wide makes the compiler keep this honest going forward.
   
   ## What changes are included in this PR?
   
   - Adds `unreachable_pub = "deny"` under `[workspace.lints.rust]` in the root `Cargo.toml`.
   
   No source files are modified in this PR — CI will surface the violations that need to be addressed (either by tightening visibility to `pub(crate)` or by genuinely re-exporting the item).
   
   ## Are these changes tested?
   
   Lint-only change; CI is the test.
   
   ## Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] chore: enable `unreachable_pub` lint at workspace level [datafusion]

["rluvaton (via GitHub)" <gi...@apache.org>]

rluvaton closed pull request #22153: chore: enable `unreachable_pub` lint at workspace level
URL: https://github.com/apache/datafusion/pull/22153


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org