[jira] [Commented] (MAPREDUCE-5748) Potential null pointer deference in ShuffleHandler#Shuffle#messageReceived()

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524766#comment-14524766 ] 

Hadoop QA commented on MAPREDUCE-5748:
--------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch |   0m  0s | The patch command could not apply the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12635637/0001-MAPREDUCE-5748-Potential-null-pointer-deference-in-S.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / f1a152c |
| Console output | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5540/console |


This message was automatically generated.

> Potential null pointer deference in ShuffleHandler#Shuffle#messageReceived()
> ----------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5748
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5748
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>         Attachments: 0001-MAPREDUCE-5748-Potential-null-pointer-deference-in-S.patch
>
>
> Starting around line 510:
> {code}
>       ChannelFuture lastMap = null;
>       for (String mapId : mapIds) {
> ...
>       }
>       lastMap.addListener(metrics);
>       lastMap.addListener(ChannelFutureListener.CLOSE);
> {code}
> If mapIds is empty, lastMap would remain null, leading to NPE in addListener() call.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)