You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/27 08:17:50 UTC
[GitHub] [airflow] csp98 opened a new pull request, #26006: Include scheduled slots in pools view
csp98 opened a new pull request, #26006:
URL: https://github.com/apache/airflow/pull/26006
closes: #25976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] BasPH commented on a diff in pull request #26006: Include scheduled slots in pools view
Posted by GitBox <gi...@apache.org>.
BasPH commented on code in PR #26006:
URL: https://github.com/apache/airflow/pull/26006#discussion_r956776461
##########
airflow/api_connexion/schemas/pool_schema.py:
##########
@@ -54,6 +55,11 @@ def get_queued_slots(obj: Pool) -> int:
"""Returns the queued slots of the pool."""
return obj.queued_slots()
+ @staticmethod
+ def get_scheduled_slots(obj: Pool) -> int:
+ """Returns the queued slots of the pool."""
Review Comment:
```suggestion
"""Returns the scheduled slots of the pool."""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] csp98 commented on pull request #26006: Include scheduled slots in pools view
Posted by GitBox <gi...@apache.org>.
csp98 commented on PR #26006:
URL: https://github.com/apache/airflow/pull/26006#issuecomment-1229540216
Sure!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] csp98 commented on pull request #26006: Include scheduled slots in pools view
Posted by GitBox <gi...@apache.org>.
csp98 commented on PR #26006:
URL: https://github.com/apache/airflow/pull/26006#issuecomment-1229572150
Ready to merge! @eladkal @uranusjr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #26006: Include scheduled slots in pools view
Posted by GitBox <gi...@apache.org>.
uranusjr merged PR #26006:
URL: https://github.com/apache/airflow/pull/26006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] BasPH commented on pull request #26006: Include scheduled slots in pools view
Posted by GitBox <gi...@apache.org>.
BasPH commented on PR #26006:
URL: https://github.com/apache/airflow/pull/26006#issuecomment-1229426183
Could you show a screenshot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org