You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@daffodil.apache.org by stevedlawrence <gi...@git.apache.org> on 2017/11/07 12:37:01 UTC
[GitHub] incubator-daffodil issue #4: Ensure marks are always returned to the markpoo...
Github user stevedlawrence commented on the issue:
https://github.com/apache/incubator-daffodil/pull/4
Note for reviewers, much of the diff is due to indentation caused by the new try/catch block. It might be easier to view this change via `git log -p -1 ae518d6c5e5f9` to ignore the whitespace changes.
---
Re: [GitHub] incubator-daffodil issue #4: Ensure marks are always
returned to the markpoo...
Posted by Mike Beckerle <mb...@tresys.com>.
git whatchanged -w -p -i hash
seems to be the right command.
________________________________
From: Mike Beckerle
Sent: Tuesday, November 7, 2017 9:45:21 AM
To: Steve Lawrence; dev@daffodil.apache.org; dev@daffodil.incubator.apache.org
Subject: Re: [GitHub] incubator-daffodil issue #4: Ensure marks are always returned to the markpoo...
The git log command is still just showing me blocks of deltas dominated by the indentation changes.
Is there a flag we need to make it ignore this?
________________________________
From: Steve Lawrence <sl...@apache.org>
Sent: Tuesday, November 7, 2017 9:18:24 AM
To: dev@daffodil.apache.org; Mike Beckerle; dev@daffodil.incubator.apache.org
Subject: Re: [GitHub] incubator-daffodil issue #4: Ensure marks are always returned to the markpoo...
Correct. My github fork is at
https://github.com/stevedlawrence/incubator-daffodil
On 11/07/2017 09:14 AM, Mike Beckerle wrote:
> To use the git log -p -1 hash suggestion, I have to pull your branch from your forked repo... which is where exactly?
>
>
> github calls it this.... but that's not the URL I need. stevedlawrence:daffodil-1862-markpool
>
> ________________________________
> From: stevedlawrence <gi...@git.apache.org>
> Sent: Tuesday, November 7, 2017 7:37:01 AM
> To: dev@daffodil.incubator.apache.org
> Subject: [GitHub] incubator-daffodil issue #4: Ensure marks are always returned to the markpoo...
>
> Github user stevedlawrence commented on the issue:
>
> https://github.com/apache/incubator-daffodil/pull/4
>
> Note for reviewers, much of the diff is due to indentation caused by the new try/catch block. It might be easier to view this change via `git log -p -1 ae518d6c5e5f9` to ignore the whitespace changes.
>
>
> ---
>
Re: [GitHub] incubator-daffodil issue #4: Ensure marks are always
returned to the markpoo...
Posted by Mike Beckerle <mb...@tresys.com>.
The git log command is still just showing me blocks of deltas dominated by the indentation changes.
Is there a flag we need to make it ignore this?
________________________________
From: Steve Lawrence <sl...@apache.org>
Sent: Tuesday, November 7, 2017 9:18:24 AM
To: dev@daffodil.apache.org; Mike Beckerle; dev@daffodil.incubator.apache.org
Subject: Re: [GitHub] incubator-daffodil issue #4: Ensure marks are always returned to the markpoo...
Correct. My github fork is at
https://github.com/stevedlawrence/incubator-daffodil
On 11/07/2017 09:14 AM, Mike Beckerle wrote:
> To use the git log -p -1 hash suggestion, I have to pull your branch from your forked repo... which is where exactly?
>
>
> github calls it this.... but that's not the URL I need. stevedlawrence:daffodil-1862-markpool
>
> ________________________________
> From: stevedlawrence <gi...@git.apache.org>
> Sent: Tuesday, November 7, 2017 7:37:01 AM
> To: dev@daffodil.incubator.apache.org
> Subject: [GitHub] incubator-daffodil issue #4: Ensure marks are always returned to the markpoo...
>
> Github user stevedlawrence commented on the issue:
>
> https://github.com/apache/incubator-daffodil/pull/4
>
> Note for reviewers, much of the diff is due to indentation caused by the new try/catch block. It might be easier to view this change via `git log -p -1 ae518d6c5e5f9` to ignore the whitespace changes.
>
>
> ---
>
Re: [GitHub] incubator-daffodil issue #4: Ensure marks are always
returned to the markpoo...
Posted by Steve Lawrence <sl...@apache.org>.
Correct. My github fork is at
https://github.com/stevedlawrence/incubator-daffodil
On 11/07/2017 09:14 AM, Mike Beckerle wrote:
> To use the git log -p -1 hash suggestion, I have to pull your branch from your forked repo... which is where exactly?
>
>
> github calls it this.... but that's not the URL I need. stevedlawrence:daffodil-1862-markpool
>
> ________________________________
> From: stevedlawrence <gi...@git.apache.org>
> Sent: Tuesday, November 7, 2017 7:37:01 AM
> To: dev@daffodil.incubator.apache.org
> Subject: [GitHub] incubator-daffodil issue #4: Ensure marks are always returned to the markpoo...
>
> Github user stevedlawrence commented on the issue:
>
> https://github.com/apache/incubator-daffodil/pull/4
>
> Note for reviewers, much of the diff is due to indentation caused by the new try/catch block. It might be easier to view this change via `git log -p -1 ae518d6c5e5f9` to ignore the whitespace changes.
>
>
> ---
>
Re: [GitHub] incubator-daffodil issue #4: Ensure marks are always
returned to the markpoo...
Posted by Mike Beckerle <mb...@tresys.com>.
To use the git log -p -1 hash suggestion, I have to pull your branch from your forked repo... which is where exactly?
github calls it this.... but that's not the URL I need. stevedlawrence:daffodil-1862-markpool
________________________________
From: stevedlawrence <gi...@git.apache.org>
Sent: Tuesday, November 7, 2017 7:37:01 AM
To: dev@daffodil.incubator.apache.org
Subject: [GitHub] incubator-daffodil issue #4: Ensure marks are always returned to the markpoo...
Github user stevedlawrence commented on the issue:
https://github.com/apache/incubator-daffodil/pull/4
Note for reviewers, much of the diff is due to indentation caused by the new try/catch block. It might be easier to view this change via `git log -p -1 ae518d6c5e5f9` to ignore the whitespace changes.
---