You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/09/03 07:29:33 UTC
[GitHub] [skywalking] lv-lifeng opened a new pull request, #9557: Add 133 134 component ID 4 impala jdbc java plugin
lv-lifeng opened a new pull request, #9557:
URL: https://github.com/apache/skywalking/pull/9557
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #9557: Add component IDs for impala JDBC Java plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #9557:
URL: https://github.com/apache/skywalking/pull/9557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9557: Add component IDs for impala JDBC Java plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9557:
URL: https://github.com/apache/skywalking/pull/9557#discussion_r962233714
##########
docs/en/changes/changes.md:
##########
@@ -5,9 +5,12 @@
#### OAP Server
+* Add component ID(133) for impala JDBC Java agent plugin and component ID(134) for impala server
#### UI
+* Add impala icon for impala JDBC Java agent plugin.
Review Comment:
This is a changelog included in your submodule update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9557: Add component IDs for impala JDBC Java plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9557:
URL: https://github.com/apache/skywalking/pull/9557#discussion_r962120054
##########
docs/en/changes/changes.md:
##########
@@ -5,9 +5,12 @@
#### OAP Server
+Add component ID(133) for impajdbcJDBCJava agent plugin and component ID(134) for impala server
#### UI
+Add impala icon for impajdbcJDBCJava agent plugin.
Review Comment:
```suggestion
* Add impala icon for impala JDBC Java agent plugin.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #9557: Add 133 134 component ID 4 impala jdbc java plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9557:
URL: https://github.com/apache/skywalking/pull/9557#issuecomment-1236067664
Please update changelog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9557: Add component IDs for impala JDBC Java plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9557:
URL: https://github.com/apache/skywalking/pull/9557#discussion_r962219048
##########
docs/en/changes/changes.md:
##########
@@ -5,9 +5,12 @@
#### OAP Server
+Add 133 134 component ID for impala jdbc java plugin.
#### UI
+Add impala icon for impala jdbc java plugin.
Review Comment:
UI PR is merged, please update the git submodule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9557: Add component IDs for impala JDBC Java plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9557:
URL: https://github.com/apache/skywalking/pull/9557#discussion_r962119971
##########
docs/en/changes/changes.md:
##########
@@ -5,9 +5,12 @@
#### OAP Server
+Add 133 134 component ID for impala jdbc java plugin.
#### UI
+Add impala icon for impala jdbc java plugin.
Review Comment:
Then we need to wait for that PR merged, and you update the UI submodule in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9557: Add component IDs for impala JDBC Java plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9557:
URL: https://github.com/apache/skywalking/pull/9557#discussion_r962233691
##########
docs/en/changes/changes.md:
##########
@@ -5,9 +5,12 @@
#### OAP Server
+* Add component ID(133) for impala JDBC Java agent plugin and component ID(134) for impala server
#### UI
+* Add impala icon for impala JDBC Java agent plugin.
Review Comment:
```suggestion
* Fix: tab active incorrectly, when click tab space
* Add impala icon for impala JDBC Java agent plugin.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9557: Add 133 134 component ID 4 impala jdbc java plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9557:
URL: https://github.com/apache/skywalking/pull/9557#discussion_r962119281
##########
docs/en/changes/changes.md:
##########
@@ -5,9 +5,12 @@
#### OAP Server
+Add 133 134 component ID for impala jdbc java plugin.
#### UI
+Add impala icon for impala jdbc java plugin.
Review Comment:
```suggestion
```
I don't think you have added the icon to UI.
##########
docs/en/changes/changes.md:
##########
@@ -5,9 +5,12 @@
#### OAP Server
+Add 133 134 component ID for impala jdbc java plugin.
Review Comment:
```suggestion
* Add component ID(133) for impajdbcJDBCJava agent plugin and component ID(134) for impala server.
```
Please be accurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lv-lifeng commented on a diff in pull request #9557: Add component IDs for impala JDBC Java plugin
Posted by GitBox <gi...@apache.org>.
lv-lifeng commented on code in PR #9557:
URL: https://github.com/apache/skywalking/pull/9557#discussion_r962119715
##########
docs/en/changes/changes.md:
##########
@@ -5,9 +5,12 @@
#### OAP Server
+Add 133 134 component ID for impala jdbc java plugin.
#### UI
+Add impala icon for impala jdbc java plugin.
Review Comment:
ui repo, https://github.com/apache/skywalking-booster-ui/pull/153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] lv-lifeng commented on a diff in pull request #9557: Add component IDs for impala JDBC Java plugin
Posted by GitBox <gi...@apache.org>.
lv-lifeng commented on code in PR #9557:
URL: https://github.com/apache/skywalking/pull/9557#discussion_r962122008
##########
docs/en/changes/changes.md:
##########
@@ -5,9 +5,12 @@
#### OAP Server
+Add 133 134 component ID for impala jdbc java plugin.
#### UI
+Add impala icon for impala jdbc java plugin.
Review Comment:
Okey.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org