You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/08/16 09:19:59 UTC
[GitHub] [iotdb] ericpai opened a new pull request #3751: [IOTDB-1568] Fix issues of blocking heartbeat broadcast and vote requesting caused…
ericpai opened a new pull request #3751:
URL: https://github.com/apache/iotdb/pull/3751
See JIRA https://issues.apache.org/jira/browse/IOTDB-1568.
In my local environment, if I set heartbeatInterval to 100ms and heartbeatTimeout to 1000ms, the heartbeat broadcast and election will last more than 1000ms because of the reconnection in `getSyncClient`. After using this patch, the issue is solved.
If anyone is familar with the cluster architecture, any suggestion or discussion is welcomed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] LebronAl commented on pull request #3751: [IOTDB-1568] Fix issues of blocking heartbeat broadcast and vote requesting caused…
Posted by GitBox <gi...@apache.org>.
LebronAl commented on pull request #3751:
URL: https://github.com/apache/iotdb/pull/3751#issuecomment-899506733
> Thanks, is this one should be cherry-picked to rel/0.12 ?
Better to do it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #3751: [IOTDB-1568] Fix issues of blocking heartbeat broadcast and vote requesting caused…
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3751:
URL: https://github.com/apache/iotdb/pull/3751#issuecomment-899385053
[](https://coveralls.io/builds/42166457)
Coverage increased (+0.02%) to 67.29% when pulling **b6c83525c954a67d83e7a49b4a75292c54d3653a on ericpai:bugfix/blocked-heartbeat-and-vote** into **337539557eac8e4d003db7a964984aeab4e3f389 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai removed a comment on pull request #3751: [IOTDB-1568] Fix issues of blocking heartbeat broadcast and vote requesting caused…
Posted by GitBox <gi...@apache.org>.
ericpai removed a comment on pull request #3751:
URL: https://github.com/apache/iotdb/pull/3751#issuecomment-899477528
> [](https://coveralls.io/builds/42166457)
>
> Coverage increased (+0.02%) to 67.29% when pulling **[b6c8352](https://github.com/apache/iotdb/commit/b6c83525c954a67d83e7a49b4a75292c54d3653a) on ericpai:bugfix/blocked-heartbeat-and-vote** into **[3375395](https://github.com/apache/iotdb/commit/337539557eac8e4d003db7a964984aeab4e3f389) on apache:master**.
Thanks, is this one should be cherry-picked to rel/0.12 ?
Here's another optimize design about cluster configurations, hope someone give advise or approvements :)
https://issues.apache.org/jira/browse/IOTDB-1564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai commented on pull request #3751: [IOTDB-1568] Fix issues of blocking heartbeat broadcast and vote requesting caused…
Posted by GitBox <gi...@apache.org>.
ericpai commented on pull request #3751:
URL: https://github.com/apache/iotdb/pull/3751#issuecomment-899477766
> Thanks for point the issue, LGTM
Thanks, is this one should be cherry-picked to rel/0.12 ?
Here's another optimize design about cluster configurations, hope someone give advise or approvements :)
https://issues.apache.org/jira/browse/IOTDB-1564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] ericpai commented on pull request #3751: [IOTDB-1568] Fix issues of blocking heartbeat broadcast and vote requesting caused…
Posted by GitBox <gi...@apache.org>.
ericpai commented on pull request #3751:
URL: https://github.com/apache/iotdb/pull/3751#issuecomment-899477528
> [](https://coveralls.io/builds/42166457)
>
> Coverage increased (+0.02%) to 67.29% when pulling **[b6c8352](https://github.com/apache/iotdb/commit/b6c83525c954a67d83e7a49b4a75292c54d3653a) on ericpai:bugfix/blocked-heartbeat-and-vote** into **[3375395](https://github.com/apache/iotdb/commit/337539557eac8e4d003db7a964984aeab4e3f389) on apache:master**.
Thanks, is this one should be cherry-picked to rel/0.12 ?
Here's another optimize design about cluster configurations, hope someone give advise or approvements :)
https://issues.apache.org/jira/browse/IOTDB-1564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] LebronAl merged pull request #3751: [IOTDB-1568] Fix issues of blocking heartbeat broadcast and vote requesting caused…
Posted by GitBox <gi...@apache.org>.
LebronAl merged pull request #3751:
URL: https://github.com/apache/iotdb/pull/3751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org