[GitHub] wu-sheng commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector

[GitBox <gi...@apache.org>]

wu-sheng commented on issue #1273: [WIP]Zipkin receiver in SkyWalking collector
URL: https://github.com/apache/incubator-skywalking/pull/1273#issuecomment-395340281
 
 
   @jcchavezs @basvanbeek @adriancole I finish the draft of transfer(not debug yet). 
   
   The most important parts of these codes are about SegmentRef and Span's peer.
   - Span's peer
   https://github.com/apache/incubator-skywalking/blob/5f66dc9a37058c12fa98cb245d92dd3cc1f82598/apm-collector/apm-collector-thirdparty-receiver/receiver-zipkin/receiver-zipkin-provider/src/main/java/org/apache/skywalking/apm/collector/receiver/zipkin/provider/transform/SegmentBuilder.java#L174-L188
   
   - SegmentRef
   https://github.com/apache/incubator-skywalking/blob/5f66dc9a37058c12fa98cb245d92dd3cc1f82598/apm-collector/apm-collector-thirdparty-receiver/receiver-zipkin/receiver-zipkin-provider/src/main/java/org/apache/skywalking/apm/collector/receiver/zipkin/provider/transform/SegmentBuilder.java#L191-L253
   
   Let me use an example to demo the important parts.
   ### FrontEnd -> BackEnd
   - Span of client in FrontEnd should have a peer, which includes ip(v4/v6/hostname)+port, representing BackEnd service endpoint. In sleuth example: `localhost:9000` in `Frontend#callBackend`
   - Span of server in BackEnd should have a ref, which includes:
      - application, instance, service from root span of the whole trace, FrontEnd in this case
      - application, instance, service from root span of parent segment, FrontEnd in this case too.
      - peer in Span of client. In sleuth example: `localhost:9000` in `Frontend#callBackend`
   
   The most important, I need Zipkin team to recheck, is about how I build peer from endpoint. I find in many cases, endpoint may miss. I think I don't get the whole picture zipkin design.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services