You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2025/11/28 09:11:17 UTC
[I] [Umbrella] Implement PendingUpdate subclasses [iceberg-cpp]
wgtmac opened a new issue, #364:
URL: https://github.com/apache/iceberg-cpp/issues/364
This issue tracks the progress of implementation of `PendingUpdate` subclasses. To implement each subclass, we need to make sure that following goals are met:
1. Implement respective functions in the [`TableMetadataBuilder`](https://github.com/apache/iceberg-cpp/blob/dbcbdf23ff7ebe5510431715fd66c7841df3d9fd/src/iceberg/table_metadata.h#L196) for this kind of update.
2. Implement respective [`TableUpdate`](https://github.com/apache/iceberg-cpp/blob/main/src/iceberg/table_update.h) subclass (if exists) to apply uncommitted changes to TableMetadataBuilder and generate update requirements.
3. Expose the new update as an interface to [`Table`](https://github.com/apache/iceberg-cpp/blob/main/src/iceberg/table.h) and [`Transaction`](https://github.com/apache/iceberg-cpp/blob/main/src/iceberg/transaction.h) classes.
Below is the list of subclasses that are expected to add.
### Non-data Update:
Unlike Java, we don't need pure interface for these classes.
- [ ] ExpireSnapshots
- [ ] ManageSnapshots (<- SnapshotManager)
- [ ] ReplaceSortOrder
- [ ] SetSnapshot
- [ ] UpdateLocation (<- SetLocation)
- [ ] UpdatePartitionSpec
- [ ] UpdatePartitionStatistics
- [ ] UpdateProperties
- [ ] UpdateSchema
- [ ] UpdateSnapshotReference
- [ ] UpdateStatistics
### Data Update:
For these classes, we still need intermediate interfaces and classes to consolidate common logic.
- [ ] SnapshotUpdate
- [ ] SnapshotProducer
- [ ] MergingSnapshotProducer
- [ ] FastAppend
- [ ] OverwriteFiles
- [ ] RowDelta
- [ ] MergeAppend
- [ ] DeleteFiles
- [ ] RewriteFiles
- [ ] ReplacePartitions
- [ ] RewriteManifests
- [ ] CherryPickOperation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [Umbrella] Implement PendingUpdate subclasses [iceberg-cpp]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on issue #364:
URL: https://github.com/apache/iceberg-cpp/issues/364#issuecomment-4514270718
@gty404 Are you working on `MergingSnapshotProducer`, which should be the base of all following snapshot APIs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [Umbrella] Implement PendingUpdate subclasses [iceberg-cpp]
Posted by "gty404 (via GitHub)" <gi...@apache.org>.
gty404 commented on issue #364:
URL: https://github.com/apache/iceberg-cpp/issues/364#issuecomment-4514374937
> [@gty404](https://github.com/gty404) Are you working on `MergingSnapshotProducer`, which should be the base of all following snapshot APIs?
Yes, I am implementing MergingSnapshot Producer and I have submitted manifest filter/merge manager, which are pre-work items for MergingSnapshot Producer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [Umbrella] Implement PendingUpdate subclasses [iceberg-cpp]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on issue #364:
URL: https://github.com/apache/iceberg-cpp/issues/364#issuecomment-4517201776
I agree that most remaining items here depend on `MergingSnapshotProducer`. Once @gty404 has finished that, feel free to pick up any unassigned work item. @manuzhang
Also cc @shangxinli @slfan1989
To expedite the review process, it would be good to follow the API design and implementation from the Java parity as much as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org