[GitHub] [trafficcontrol] zrhoffman opened a new issue #5154: Prohibit deleting the last server in a cachegroup that is assigned to a Topology

[GitBox <gi...@apache.org>]

zrhoffman opened a new issue #5154:
URL: https://github.com/apache/trafficcontrol/issues/5154


   <!--
   ************ STOP!! ************
   If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
   the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
   
   - For *SUPPORT QUESTIONS*, use the Traffic Control slack (https://s.apache.org/atc-slack)
   or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists).
   - Before submitting, please **SEARCH GITHUB** for a similar issue or PR.
   -->
   
   ## I'm submitting a ...
   <!-- delete all those that don't apply -->
   <!--- security vulnerability (STOP!! - see above)-->
   -  new feature / enhancement request
   
   ## Traffic Control components affected ...
   <!-- delete all those that don't apply -->
   -  Traffic Ops
   
   ## Current behavior:
   <!-- Describe how the current features are insufficient. -->
   Servers can be deleted or removed from a Cache Group used by a Topology, even if it means that Cache Group would no longer have any Servers in it.
   
   #5144 already added this validation for `POST` and `PUT /api/3.0/topologies`, so if such a Server was deleted or moved to a different Cache Group, updating that Topology would then fail, as long as the Topology still contains that Cache Group.
   
   ## New behavior:
   <!-- Describe how the feature would improve Traffic Control -->
   As a CDN operator, I would like to prevent deleting the last server in a Cache Group that is assigned to any Topology. With no Servers in a Cache Group assigned to a Topology, that Topology is no longer valid, so the Cachegroup should be removed from the Topology before the last server can be deleted from it.
   
   ## Minimal reproduction of the problem with instructions:
   <!--
   If you can illustrate your feature request better with an example, please
   provide the *STEPS TO REPRODUCE* and include the applicable TC version.
   If not, feel free to delete this section.
   -->
   For DELETE:
   1. Make a Cache Group
   2. Add only 1 Server to the Cache Group
   3. Make a Topology
   4. Delete the Server (should fail)
   
   For PUT:
   1. Make a Cache Group
   2. Add only 1 Server to the Cache Group
   3. Make a Topology
   4. Move the Server to a different Cache Group (should fail)
   
   <!--
       Licensed to the Apache Software Foundation (ASF) under one
       or more contributor license agreements.  See the NOTICE file
       distributed with this work for additional information
       regarding copyright ownership.  The ASF licenses this file
       to you under the Apache License, Version 2.0 (the
       "License"); you may not use this file except in compliance
       with the License.  You may obtain a copy of the License at
   
       https://apache.org/licenses/LICENSE-2.0
   
       Unless required by applicable law or agreed to in writing,
       software distributed under the License is distributed on an
       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
       KIND, either express or implied.  See the License for the
       specific language governing permissions and limitations
       under the License.
   -->


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rawlinp closed issue #5154: Traffic Ops should prohibit deleting the last Server in a Cache Group that is assigned to a Topology

[GitBox <gi...@apache.org>]

rawlinp closed issue #5154:
URL: https://github.com/apache/trafficcontrol/issues/5154


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org