You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/12/16 15:37:47 UTC
[GitHub] [lucene] gsmiller opened a new pull request #547: LUCENE-10321: Tweak MultiRangeQuery interval tree creation logic
gsmiller opened a new pull request #547:
URL: https://github.com/apache/lucene/pull/547
# Description
Small tweak that makes the interval tree creation logic in MultiRangeQuery consistent with ComponentTree.
# Solution
Just remove the "roll up" of min values since internal node bounding boxes don't need consistent min values.
# Tests
All existing tests continue to pass.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller commented on pull request #547: LUCENE-10321: Tweak MultiRangeQuery interval tree creation logic
Posted by GitBox <gi...@apache.org>.
gsmiller commented on pull request #547:
URL: https://github.com/apache/lucene/pull/547#issuecomment-996122277
> I would prefer if RangeTree does not implement Range any more as it does not follow the contract. What do you think?
+1 makes sense
> So I was thinking we can remove this part as well:
Yeah, good catch!
I think my new revision addresses both of these suggestions. Thanks for the quick feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gsmiller merged pull request #547: LUCENE-10321: Tweak MultiRangeQuery interval tree creation logic
Posted by GitBox <gi...@apache.org>.
gsmiller merged pull request #547:
URL: https://github.com/apache/lucene/pull/547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org