You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/04/23 01:18:10 UTC

[GitHub] [helix] jiajunwang opened a new pull request #1710: Fix the unstable test TestDisableCustomCodeRunner.

jiajunwang opened a new pull request #1710:
URL: https://github.com/apache/helix/pull/1710


   ### Issues
   
   - [X] My PR addresses the following Helix issues and references them in the PR description:
   
   Fixes #1299 
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   
   Change the validate condition so it covers the expected and possible race conditions without failing the test.
   
   ### Tests
   
   - [X] The following tests are written for this issue:
   
   Pure test change.
   
   - The following is the result of the "mvn test" command on the appropriate module:
   
   (If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
   
   ### Documentation (Optional)
   
   - In case of new functionality, my PR adds documentation in the following wiki page:
   
   (Link the GitHub wiki you added)
   
   ### Commits
   
   - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] jiajunwang merged pull request #1710: Fix the unstable test TestDisableCustomCodeRunner.

Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #1710:
URL: https://github.com/apache/helix/pull/1710


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] jiajunwang commented on pull request #1710: Fix the unstable test TestDisableCustomCodeRunner.

Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1710:
URL: https://github.com/apache/helix/pull/1710#issuecomment-825831506


   Approved by @xyuanlu , ready to approve.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] jiajunwang edited a comment on pull request #1710: Fix the unstable test TestDisableCustomCodeRunner.

Posted by GitBox <gi...@apache.org>.
jiajunwang edited a comment on pull request #1710:
URL: https://github.com/apache/helix/pull/1710#issuecomment-825831506


   Approved by @xyuanlu , ready to merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org