You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/17 21:42:22 UTC
[GitHub] [airflow] gmcrocetti opened a new pull request #17667: [DOCS] Update DAG.is_active property
gmcrocetti opened a new pull request #17667:
URL: https://github.com/apache/airflow/pull/17667
Description
---
Pretty simple patch updating documentation. Adds `readOnly=True` to `DAG.is_active`.
closes: #17639
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17667: [DOCS] Update DAG.is_active property
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17667:
URL: https://github.com/apache/airflow/pull/17667#issuecomment-900832092
One pedantic nit; why change the ordering?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] gmcrocetti commented on pull request #17667: [DOCS] Update DAG.is_active property
Posted by GitBox <gi...@apache.org>.
gmcrocetti commented on pull request #17667:
URL: https://github.com/apache/airflow/pull/17667#issuecomment-901315616
> One pedantic nit; why change the ordering?
Just sorted alphabetically; I think it improves readability in both sides, the end-user reading the API (the order is preserved for some fields when converting to HTML) and the developer. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #17667: [DOCS] Update DAG.is_active property
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #17667:
URL: https://github.com/apache/airflow/pull/17667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17667: [DOCS] Update DAG.is_active property
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17667:
URL: https://github.com/apache/airflow/pull/17667#issuecomment-900658458
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17667: [DOCS] Update DAG.is_active property
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17667:
URL: https://github.com/apache/airflow/pull/17667#issuecomment-900658458
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17667: [DOCS] Update DAG.is_active property
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17667:
URL: https://github.com/apache/airflow/pull/17667#issuecomment-900832092
One pedantic nit; why change the ordering?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #17667: [DOCS] Update DAG.is_active property
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #17667:
URL: https://github.com/apache/airflow/pull/17667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org