You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/11/17 20:32:28 UTC

[GitHub] [couchdb-b64url] nickva commented on pull request #9: Format code with erlfmt, run dialyzer in CI

nickva commented on pull request #9:
URL: https://github.com/apache/couchdb-b64url/pull/9#issuecomment-971971037


   > Is that a bad thing?
   
   It's not bad but could be inconvenient.  The formatting itself is fine. However, since in 3.x `erlfmt` makefile setup doesn't work yet (because the minimum OTP version for `erlfmt` is 21), someone developing in 3.x would be forced to switch to OTP 21+ just to re-format this dependency.
   
   For the time being, could we make it so the CI check emits a warning instead of failing the build, with a comment to enforce it later after.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org