You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "featzhang (via GitHub)" <gi...@apache.org> on 2023/01/23 15:36:58 UTC
[GitHub] [inlong] featzhang opened a new pull request, #7267: [INLONG-7264][Dashboard] Support sink Apache Kudu
featzhang opened a new pull request, #7267:
URL: https://github.com/apache/inlong/pull/7267
### Prepare a Pull Request
- [INLONG-7264][Dashboard] Support sink Apache Kudu
- Fixes #7264
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [x] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] featzhang closed pull request #7267: [INLONG-7264][Dashboard] Support sink Apache Kudu
Posted by "featzhang (via GitHub)" <gi...@apache.org>.
featzhang closed pull request #7267: [INLONG-7264][Dashboard] Support sink Apache Kudu
URL: https://github.com/apache/inlong/pull/7267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] featzhang commented on a diff in pull request #7267: [INLONG-7264][Dashboard] Support sink Apache Kudu
Posted by "featzhang (via GitHub)" <gi...@apache.org>.
featzhang commented on code in PR #7267:
URL: https://github.com/apache/inlong/pull/7267#discussion_r1086748815
##########
inlong-dashboard/src/locales/cn.json:
##########
@@ -344,6 +344,17 @@
"meta.Sinks.Redis.DataSeparator.Asterisk": "星号(*)",
"meta.Sinks.Redis.DataSeparator.DoubleQuotes": "双引号(\")",
"meta.Sinks.Redis.FormatDataSeparator": "数据字段分隔符",
+ "meta.Sinks.Kudu.masters": "masters",
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] featzhang closed pull request #7267: [INLONG-7264][Dashboard] Support sink Apache Kudu
Posted by "featzhang (via GitHub)" <gi...@apache.org>.
featzhang closed pull request #7267: [INLONG-7264][Dashboard] Support sink Apache Kudu
URL: https://github.com/apache/inlong/pull/7267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7267: [INLONG-7264][Dashboard] Support sink Apache Kudu
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7267:
URL: https://github.com/apache/inlong/pull/7267#discussion_r1086685393
##########
inlong-dashboard/src/locales/cn.json:
##########
@@ -344,6 +344,17 @@
"meta.Sinks.Redis.DataSeparator.Asterisk": "星号(*)",
"meta.Sinks.Redis.DataSeparator.DoubleQuotes": "双引号(\")",
"meta.Sinks.Redis.FormatDataSeparator": "数据字段分隔符",
+ "meta.Sinks.Kudu.masters": "masters",
Review Comment:
Did this `masters` need i18n?
##########
inlong-dashboard/src/locales/en.json:
##########
@@ -344,6 +344,17 @@
"meta.Sinks.Redis.DataSeparator.Asterisk": "Asterisk(*)",
"meta.Sinks.Redis.DataSeparator.DoubleQuotes": "Double quotes(\")",
"meta.Sinks.Redis.FormatDataSeparator": "Data separator",
+ "meta.Sinks.Kudu.masters": "masters",
+ "meta.Sinks.Kudu.TableName": "Table",
+ "meta.Sinks.Kudu.ExtListHelper": "The DDL attribute of the hudi table needs to be prefixed with 'ddl.'",
+ "meta.Sinks.Kudu.ExtList": "ExtList",
Review Comment:
```suggestion
"meta.Sinks.Kudu.ExtListHelper": "The DDL attribute of the Kudu table needs to be prefixed with 'ddl.'",
"meta.Sinks.Kudu.ExtList": "Extenstion params",
```
##########
inlong-dashboard/src/locales/en.json:
##########
@@ -344,6 +344,17 @@
"meta.Sinks.Redis.DataSeparator.Asterisk": "Asterisk(*)",
"meta.Sinks.Redis.DataSeparator.DoubleQuotes": "Double quotes(\")",
"meta.Sinks.Redis.FormatDataSeparator": "Data separator",
+ "meta.Sinks.Kudu.masters": "masters",
Review Comment:
ditto.
##########
inlong-dashboard/src/locales/cn.json:
##########
@@ -344,6 +344,17 @@
"meta.Sinks.Redis.DataSeparator.Asterisk": "星号(*)",
"meta.Sinks.Redis.DataSeparator.DoubleQuotes": "双引号(\")",
"meta.Sinks.Redis.FormatDataSeparator": "数据字段分隔符",
+ "meta.Sinks.Kudu.masters": "masters",
+ "meta.Sinks.Kudu.TableName": "表名",
+ "meta.Sinks.Kudu.ExtListHelper": "kudu表的DDL属性需带前缀'ddl.'",
Review Comment:
```suggestion
"meta.Sinks.Kudu.ExtListHelper": "Kudu 表的 DDL 属性需添加'ddl.'前缀",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] featzhang commented on a diff in pull request #7267: [INLONG-7264][Dashboard] Support sink Apache Kudu
Posted by "featzhang (via GitHub)" <gi...@apache.org>.
featzhang commented on code in PR #7267:
URL: https://github.com/apache/inlong/pull/7267#discussion_r1086751640
##########
inlong-dashboard/src/locales/en.json:
##########
@@ -344,6 +344,17 @@
"meta.Sinks.Redis.DataSeparator.Asterisk": "Asterisk(*)",
"meta.Sinks.Redis.DataSeparator.DoubleQuotes": "Double quotes(\")",
"meta.Sinks.Redis.FormatDataSeparator": "Data separator",
+ "meta.Sinks.Kudu.masters": "masters",
Review Comment:
The English name 'masters' should not require additional expressions, as it is written on the official website.
https://kudu.apache.org/docs/administration.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #7267: [INLONG-7264][Dashboard] Support sink Apache Kudu
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7267:
URL: https://github.com/apache/inlong/pull/7267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org