You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/03/22 17:40:02 UTC

[GitHub] [arrow] ch-sc opened a new pull request #9772: ARROW-11973 Boolean kleene kernels

ch-sc opened a new pull request #9772:
URL: https://github.com/apache/arrow/pull/9772


   This PR adds two boolean kernels `kleene_or` and `kleene_and`.
   
   As described in the corresponding [JIRA ticket](https://issues.apache.org/jira/browse/ARROW-11973), the kleene operator handels null values differently compared to plain OR and AND operators. 
   
   
   | Operator | Left       | Right  | Result   |
   | -----------: | ----------:| --------:| ---------: |
   | AND        | TRUE   | NULL | NULL    |
   | AND        | FALSE  | NULL | FALSE |
   | OR          | TRUE   | NULL | TRUE   |
   | OR          | FALSE  | NULL | NULL   |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ch-sc commented on pull request #9772: ARROW-11973 [Rust] Boolean kleene kernels

Posted by GitBox <gi...@apache.org>.
ch-sc commented on pull request #9772:
URL: https://github.com/apache/arrow/pull/9772#issuecomment-804367750


   Hi @Dandandan, I actaully checked on Postgres (11) beforehand and it did return exactly the values I provided in the table.
   
   ```
   SELECT TRUE AND NULL; --> NULL
   SELECT FALSE AND NULL; --> FALSE
   SELECT TRUE OR NULL; --> TRUE
   SELECT FALSE OR NULL; --> NULL
   ```
   
   Which Postgres version are you using?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #9772: ARROW-11973 [Rust] Boolean kleene kernels

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9772:
URL: https://github.com/apache/arrow/pull/9772#issuecomment-804378434


   https://issues.apache.org/jira/browse/ARROW-11973


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorgecarleitao commented on pull request #9772: ARROW-11973 [Rust] Boolean kleene kernels

Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #9772:
URL: https://github.com/apache/arrow/pull/9772#issuecomment-804370136


   I tried on mysql, postgres and big query and was happy with the table you provided on JIRA. I am also curious how I got a different result than @Dandandan  xD 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] Dandandan commented on pull request #9772: ARROW-11973 [Rust] Boolean kleene kernels

Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #9772:
URL: https://github.com/apache/arrow/pull/9772#issuecomment-804312560


   @ch-sc thanks for your PR
   
   In the JIRA ticket it is mentioned that these semantics are default for SQL - however - these return `NULL` in PostgreSQL (the dialect we want to target for DataFusion.
   
   ```
   SELECT TRUE AND NULL;
   SELECT TRUE OR NULL;
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] Dandandan edited a comment on pull request #9772: ARROW-11973 [Rust] Boolean kleene kernels

Posted by GitBox <gi...@apache.org>.
Dandandan edited a comment on pull request #9772:
URL: https://github.com/apache/arrow/pull/9772#issuecomment-804312560


   @ch-sc thanks for your PR
   
   In the JIRA ticket it is mentioned that these semantics are default for SQL - however - these return `NULL` in PostgreSQL (the dialect we want to target for DataFusion.
   
   ```
   SELECT TRUE AND NULL;
   SELECT TRUE OR NULL;
   ```
   
   I think it is a useful addition to Arrow side though - for DataFusion we should just think about what behavior we want to support.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb commented on pull request #9772: ARROW-11973 [Rust][DataFusion] Boolean kleene kernels

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9772:
URL: https://github.com/apache/arrow/pull/9772#issuecomment-810179385


   For the record the issue of the integration test running out of space is known and not related to this PR
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io commented on pull request #9772: ARROW-11973 [Rust][DataFusion] Boolean kleene kernels

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9772:
URL: https://github.com/apache/arrow/pull/9772#issuecomment-808097956


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9772?src=pr&el=h1) Report
   > Merging [#9772](https://codecov.io/gh/apache/arrow/pull/9772?src=pr&el=desc) (d024f2b) into [master](https://codecov.io/gh/apache/arrow/commit/29feea07fea118ad6ffc4d2615a5798412fe2f19?el=desc) (29feea0) will **decrease** coverage by `0.23%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9772/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9772?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9772      +/-   ##
   ==========================================
   - Coverage   82.59%   82.36%   -0.24%     
   ==========================================
     Files         248      252       +4     
     Lines       58294    58893     +599     
   ==========================================
   + Hits        48149    48507     +358     
   - Misses      10145    10386     +241     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9772?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/arrow/src/array/transform/fixed\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9772/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL2ZpeGVkX2JpbmFyeS5ycw==) | `5.26% <0.00%> (-73.69%)` | :arrow_down: |
   | [rust/arrow/src/array/transform/null.rs](https://codecov.io/gh/apache/arrow/pull/9772/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL251bGwucnM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [rust/arrow/src/array/transform/structure.rs](https://codecov.io/gh/apache/arrow/pull/9772/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3N0cnVjdHVyZS5ycw==) | `44.44% <0.00%> (-38.89%)` | :arrow_down: |
   | [rust/arrow/src/array/transform/primitive.rs](https://codecov.io/gh/apache/arrow/pull/9772/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3ByaW1pdGl2ZS5ycw==) | `71.42% <0.00%> (-28.58%)` | :arrow_down: |
   | [rust/arrow/src/array/transform/mod.rs](https://codecov.io/gh/apache/arrow/pull/9772/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL21vZC5ycw==) | `70.23% <0.00%> (-22.96%)` | :arrow_down: |
   | [rust/arrow/src/array/transform/variable\_size.rs](https://codecov.io/gh/apache/arrow/pull/9772/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL3ZhcmlhYmxlX3NpemUucnM=) | `87.87% <0.00%> (-12.13%)` | :arrow_down: |
   | [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9772/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `79.84% <0.00%> (-11.80%)` | :arrow_down: |
   | [rust/parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow/pull/9772/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9hcnJvdy9zY2hlbWEucnM=) | `86.57% <0.00%> (-5.79%)` | :arrow_down: |
   | [rust/arrow/src/buffer/mutable.rs](https://codecov.io/gh/apache/arrow/pull/9772/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYnVmZmVyL211dGFibGUucnM=) | `87.73% <0.00%> (-3.04%)` | :arrow_down: |
   | [rust/arrow/src/array/array\_union.rs](https://codecov.io/gh/apache/arrow/pull/9772/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfdW5pb24ucnM=) | `87.17% <0.00%> (-2.37%)` | :arrow_down: |
   | ... and [58 more](https://codecov.io/gh/apache/arrow/pull/9772/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9772?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9772?src=pr&el=footer). Last update [a2a9f5d...d024f2b](https://codecov.io/gh/apache/arrow/pull/9772?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] Dandandan edited a comment on pull request #9772: ARROW-11973 [Rust] Boolean kleene kernels

Posted by GitBox <gi...@apache.org>.
Dandandan edited a comment on pull request #9772:
URL: https://github.com/apache/arrow/pull/9772#issuecomment-804390782


   Haha @ch-sc  @jorgecarleitao  I tried it on this website which I used before for some simple checks https://rextester.com/l/postgresql_online_compiler
   but it shows `null` on every input now 🤣
   
   So forget what I said, it is very useful to do this both for Arrow & DataFusion :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] Dandandan edited a comment on pull request #9772: ARROW-11973 [Rust] Boolean kleene kernels

Posted by GitBox <gi...@apache.org>.
Dandandan edited a comment on pull request #9772:
URL: https://github.com/apache/arrow/pull/9772#issuecomment-804390782


   Haha @ch-sc  @javierluraschi I tried it on this website which I used before for some simple checks https://rextester.com/l/postgresql_online_compiler
   but it shows `null` on every input now 🤣
   
   So forget what I said, it is very useful to do this both for Arrow & DataFusion :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] alamb closed pull request #9772: ARROW-11973 [Rust][DataFusion] Boolean kleene kernels

Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9772:
URL: https://github.com/apache/arrow/pull/9772


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ch-sc commented on pull request #9772: ARROW-11973 [Rust][DataFusion] Boolean kleene kernels

Posted by GitBox <gi...@apache.org>.
ch-sc commented on pull request #9772:
URL: https://github.com/apache/arrow/pull/9772#issuecomment-808170879


   @Dandandan @jorgecarleitao the integration tests fail because of scarce disk space:
   ```
   + npm install
   ##[warning]You are running out of disk space. The runner will stop working when the machine runs out of disk space. Free space left: 57 MB
   npm WARN tar ENOSPC: no space left on device, write
   ```
   
   Any ideas what we can do about this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] Dandandan commented on pull request #9772: ARROW-11973 [Rust] Boolean kleene kernels

Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #9772:
URL: https://github.com/apache/arrow/pull/9772#issuecomment-804390782


   Haha @ch-sc  @javierluraschi I tried it on this website which I used before https://rextester.com/l/postgresql_online_compiler
   but it shows `null` on every input now 🤣
   
   So forget what I said, it is very useful to do this both for Arrow & DataFusion :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org