You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by Nick Burch <ap...@gagravarr.org> on 2014/02/02 12:47:25 UTC

Re: svn commit: r1563540 - in /poi: site/src/documentation/content/xdocs/ trunk/src/ooxml/java/org/apache/poi/openxml4j/opc/ trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/ trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/ trunk/test-data/spread...

On Sun, 2 Feb 2014, kiwiwings@apache.org wrote:
> public final class PackageRelationshipCollection implements
> -		Iterable<PackageRelationship> {
> +        Iterable<PackageRelationship> {
>
>     private static POILogger logger = POILogFactory.getLogger(PackageRelationshipCollection.class);
>
> -	/**
> -	 * Package relationships ordered by ID.
> -	 */

Minor thing, but if you find yourself working on a file with inconsistent 
line endings / whitespace, it's generally better to do two commits. One 
commit to fix up the whitespace, a second for the actual logic changes.

If they're split out, then it's very easy to review the change from the 
diff email. If they go in together, reviewing means more faffing with svn 
diff to exclude whitespace, so it's a lot harder, and hence fewer people 
will review!

Nick

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org