You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/06/03 17:21:27 UTC

[GitHub] [tvm] Lunderberg opened a new pull request #8188: [Vulkan][Refactor] Pull out vulkan initialization into VulkanInstance and VulkanDevice

Lunderberg opened a new pull request #8188:
URL: https://github.com/apache/tvm/pull/8188


   Next step of the refactoring initiated in #8157.  Each of the following changes is implemented in a separate commit in this PR.
   
   - Broke out `VkInstance` setup/teardown into managed class.  Previously, the `VkInstance` was directly owned by the `VulkanDeviceAPI`.  Now, `VulkanDeviceAPI` owns a `tvm::runtime::vulkan::VulkanInstance` that does setup/teardown of the `VkInstance`.  This way, the teardown is done even if a later initialization step throws an exception.
   
   - Renamed `VulkanContext` to `VulkanDevice`, to match with the `tvm.context` to `tvm.device` rename.
   
   - Extracted `VulkanDevice` initialization into `VulkanDevice` class
   
   - Removed the `VkPhysicalDeviceProperties` member variable from `VulkanDevice`.  With the separate `VulkanDeviceProperties` class, this moves all device parameter query/access to a single path.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #8188: [Vulkan][Refactor] Pull out vulkan initialization into VulkanInstance and VulkanDevice

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #8188:
URL: https://github.com/apache/tvm/pull/8188


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #8188: [Vulkan][Refactor] Pull out vulkan initialization into VulkanInstance and VulkanDevice

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #8188:
URL: https://github.com/apache/tvm/pull/8188#issuecomment-854382654


   thanks @Lunderberg 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #8188: [Vulkan][Refactor] Pull out vulkan initialization into VulkanInstance and VulkanDevice

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #8188:
URL: https://github.com/apache/tvm/pull/8188#issuecomment-854382654


   thanks @Lunderberg 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #8188: [Vulkan][Refactor] Pull out vulkan initialization into VulkanInstance and VulkanDevice

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #8188:
URL: https://github.com/apache/tvm/pull/8188


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Lunderberg commented on pull request #8188: [Vulkan][Refactor] Pull out vulkan initialization into VulkanInstance and VulkanDevice

Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #8188:
URL: https://github.com/apache/tvm/pull/8188#issuecomment-854044895


   Potential reviewers: @masahi @tmoreau89 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Lunderberg commented on pull request #8188: [Vulkan][Refactor] Pull out vulkan initialization into VulkanInstance and VulkanDevice

Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #8188:
URL: https://github.com/apache/tvm/pull/8188#issuecomment-854044895


   Potential reviewers: @masahi @tmoreau89 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org