You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/22 07:17:40 UTC
[GitHub] [airflow] raphaelauv opened a new pull request #14928: Fix typo doc docker-stack
raphaelauv opened a new pull request #14928:
URL: https://github.com/apache/airflow/pull/14928
Fix a typo on doc , the _AIRFLOW_WWW_USER_PASSWORD_CMD is repeated two times
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG merged pull request #14928: Fix typo doc docker-stack
Posted by GitBox <gi...@apache.org>.
XD-DENG merged pull request #14928:
URL: https://github.com/apache/airflow/pull/14928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #14928: Fix typo doc docker-stack
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #14928:
URL: https://github.com/apache/airflow/pull/14928#discussion_r598540649
##########
File path: docs/docker-stack/entrypoint.rst
##########
@@ -131,7 +131,7 @@ The entrypoint can also create webserver user automatically when you enter it. y
``_AIRFLOW_WWW_USER_CREATE`` to a non-empty value in order to do that. This is not intended for
production, it is only useful if you would like to run a quick test with the production image.
You need to pass at least password to create such user via ``_AIRFLOW_WWW_USER_PASSWORD_CMD`` or
-``_AIRFLOW_WWW_USER_PASSWORD_CMD`` similarly like for other ``*_CMD`` variables, the content of
+``_AIRFLOW_WWW_USER_PASSWORD`` similarly like for other ``*_CMD`` variables, the content of
Review comment:
Thanks @raphaelauv .
I agree this is a typo. But by reading through the sentence, I think the order of ``_AIRFLOW_WWW_USER_PASSWORD_CMD`` and ``_AIRFLOW_WWW_USER_PASSWORD`` should be swapped in your change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] raphaelauv commented on a change in pull request #14928: Fix typo doc docker-stack
Posted by GitBox <gi...@apache.org>.
raphaelauv commented on a change in pull request #14928:
URL: https://github.com/apache/airflow/pull/14928#discussion_r598571991
##########
File path: docs/docker-stack/entrypoint.rst
##########
@@ -131,7 +131,7 @@ The entrypoint can also create webserver user automatically when you enter it. y
``_AIRFLOW_WWW_USER_CREATE`` to a non-empty value in order to do that. This is not intended for
production, it is only useful if you would like to run a quick test with the production image.
You need to pass at least password to create such user via ``_AIRFLOW_WWW_USER_PASSWORD_CMD`` or
-``_AIRFLOW_WWW_USER_PASSWORD_CMD`` similarly like for other ``*_CMD`` variables, the content of
+``_AIRFLOW_WWW_USER_PASSWORD`` similarly like for other ``*_CMD`` variables, the content of
Review comment:
done , thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #14928: Fix typo doc docker-stack
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #14928:
URL: https://github.com/apache/airflow/pull/14928#discussion_r598574523
##########
File path: docs/docker-stack/entrypoint.rst
##########
@@ -131,7 +131,7 @@ The entrypoint can also create webserver user automatically when you enter it. y
``_AIRFLOW_WWW_USER_CREATE`` to a non-empty value in order to do that. This is not intended for
production, it is only useful if you would like to run a quick test with the production image.
You need to pass at least password to create such user via ``_AIRFLOW_WWW_USER_PASSWORD_CMD`` or
-``_AIRFLOW_WWW_USER_PASSWORD_CMD`` similarly like for other ``*_CMD`` variables, the content of
+``_AIRFLOW_WWW_USER_PASSWORD`` similarly like for other ``*_CMD`` variables, the content of
Review comment:
Merci :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org