You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2012/11/29 22:06:59 UTC
[jira] [Created] (HDFS-4242) Map.Entry is incorrectly used in
LeaseManager
Tsz Wo (Nicholas), SZE created HDFS-4242:
--------------------------------------------
Summary: Map.Entry is incorrectly used in LeaseManager
Key: HDFS-4242
URL: https://issues.apache.org/jira/browse/HDFS-4242
Project: Hadoop HDFS
Issue Type: Bug
Components: namenode
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
As Daryn pointed out, the behavior of [Map.Entry|http://docs.oracle.com/javase/6/docs/api/java/util/Map.Entry.html] is undefined after the iteration or modifications of the map.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4242) Map.Entry is incorrectly used in
LeaseManager
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-4242:
-----------------------------------------
Attachment: h4242_20121129.patch
h4242_20121129.patch: return Map<String, Lease> instead of List<Map.Entry<String, Lease>>.
> Map.Entry is incorrectly used in LeaseManager
> ---------------------------------------------
>
> Key: HDFS-4242
> URL: https://issues.apache.org/jira/browse/HDFS-4242
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h4242_20121129.patch
>
>
> As Daryn pointed out, the behavior of [Map.Entry|http://docs.oracle.com/javase/6/docs/api/java/util/Map.Entry.html] is undefined after the iteration or modifications of the map.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4242) Map.Entry is incorrectly used in
LeaseManager
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506930#comment-13506930 ]
Hadoop QA commented on HDFS-4242:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12555407/h4242_20121129.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3577//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3577//console
This message is automatically generated.
> Map.Entry is incorrectly used in LeaseManager
> ---------------------------------------------
>
> Key: HDFS-4242
> URL: https://issues.apache.org/jira/browse/HDFS-4242
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h4242_20121129.patch
>
>
> As Daryn pointed out, the behavior of [Map.Entry|http://docs.oracle.com/javase/6/docs/api/java/util/Map.Entry.html] is undefined after the iteration or modifications of the map.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4242) Map.Entry is incorrectly used in
LeaseManager
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507950#comment-13507950 ]
Hudson commented on HDFS-4242:
------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #452 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/452/])
HDFS-4242. Map.Entry is incorrectly used in LeaseManager since the behavior of it is undefined after the iteration or modifications of the map. (szetszwo via daryn) (Revision 1415682)
Result = SUCCESS
daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415682
Files :
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
> Map.Entry is incorrectly used in LeaseManager
> ---------------------------------------------
>
> Key: HDFS-4242
> URL: https://issues.apache.org/jira/browse/HDFS-4242
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 2.0.3-alpha, 0.23.6
>
> Attachments: h4242_20121129.patch
>
>
> As Daryn pointed out, the behavior of [Map.Entry|http://docs.oracle.com/javase/6/docs/api/java/util/Map.Entry.html] is undefined after the iteration or modifications of the map.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4242) Map.Entry is incorrectly used in
LeaseManager
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507312#comment-13507312 ]
Hudson commented on HDFS-4242:
------------------------------
Integrated in Hadoop-Hdfs-trunk #1242 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1242/])
HDFS-4242. Map.Entry is incorrectly used in LeaseManager since the behavior of it is undefined after the iteration or modifications of the map. (Revision 1415480)
Result = FAILURE
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415480
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
> Map.Entry is incorrectly used in LeaseManager
> ---------------------------------------------
>
> Key: HDFS-4242
> URL: https://issues.apache.org/jira/browse/HDFS-4242
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 2.0.3-alpha
>
> Attachments: h4242_20121129.patch
>
>
> As Daryn pointed out, the behavior of [Map.Entry|http://docs.oracle.com/javase/6/docs/api/java/util/Map.Entry.html] is undefined after the iteration or modifications of the map.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4242) Map.Entry is incorrectly used in
LeaseManager
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507258#comment-13507258 ]
Hudson commented on HDFS-4242:
------------------------------
Integrated in Hadoop-Yarn-trunk #52 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/52/])
HDFS-4242. Map.Entry is incorrectly used in LeaseManager since the behavior of it is undefined after the iteration or modifications of the map. (Revision 1415480)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415480
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
> Map.Entry is incorrectly used in LeaseManager
> ---------------------------------------------
>
> Key: HDFS-4242
> URL: https://issues.apache.org/jira/browse/HDFS-4242
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 2.0.3-alpha
>
> Attachments: h4242_20121129.patch
>
>
> As Daryn pointed out, the behavior of [Map.Entry|http://docs.oracle.com/javase/6/docs/api/java/util/Map.Entry.html] is undefined after the iteration or modifications of the map.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4242) Map.Entry is incorrectly used in
LeaseManager
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-4242:
-----------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.3-alpha
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Aaron, thanks for the review.
I have committed this.
> Map.Entry is incorrectly used in LeaseManager
> ---------------------------------------------
>
> Key: HDFS-4242
> URL: https://issues.apache.org/jira/browse/HDFS-4242
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 2.0.3-alpha
>
> Attachments: h4242_20121129.patch
>
>
> As Daryn pointed out, the behavior of [Map.Entry|http://docs.oracle.com/javase/6/docs/api/java/util/Map.Entry.html] is undefined after the iteration or modifications of the map.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4242) Map.Entry is incorrectly used in
LeaseManager
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-4242:
-----------------------------------------
Status: Patch Available (was: Open)
> Map.Entry is incorrectly used in LeaseManager
> ---------------------------------------------
>
> Key: HDFS-4242
> URL: https://issues.apache.org/jira/browse/HDFS-4242
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h4242_20121129.patch
>
>
> As Daryn pointed out, the behavior of [Map.Entry|http://docs.oracle.com/javase/6/docs/api/java/util/Map.Entry.html] is undefined after the iteration or modifications of the map.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4242) Map.Entry is incorrectly used in
LeaseManager
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507338#comment-13507338 ]
Hudson commented on HDFS-4242:
------------------------------
Integrated in Hadoop-Mapreduce-trunk #1273 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1273/])
HDFS-4242. Map.Entry is incorrectly used in LeaseManager since the behavior of it is undefined after the iteration or modifications of the map. (Revision 1415480)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415480
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
> Map.Entry is incorrectly used in LeaseManager
> ---------------------------------------------
>
> Key: HDFS-4242
> URL: https://issues.apache.org/jira/browse/HDFS-4242
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 2.0.3-alpha
>
> Attachments: h4242_20121129.patch
>
>
> As Daryn pointed out, the behavior of [Map.Entry|http://docs.oracle.com/javase/6/docs/api/java/util/Map.Entry.html] is undefined after the iteration or modifications of the map.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4242) Map.Entry is incorrectly used in
LeaseManager
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HDFS-4242:
------------------------------
Fix Version/s: 0.23.6
I pulled this back into 23. Someone should help investigate if the same fix is required in 1.x. Otherwise I'll try to look into it after getting all related patches integrated.
> Map.Entry is incorrectly used in LeaseManager
> ---------------------------------------------
>
> Key: HDFS-4242
> URL: https://issues.apache.org/jira/browse/HDFS-4242
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 2.0.3-alpha, 0.23.6
>
> Attachments: h4242_20121129.patch
>
>
> As Daryn pointed out, the behavior of [Map.Entry|http://docs.oracle.com/javase/6/docs/api/java/util/Map.Entry.html] is undefined after the iteration or modifications of the map.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4242) Map.Entry is incorrectly used in
LeaseManager
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507057#comment-13507057 ]
Hudson commented on HDFS-4242:
------------------------------
Integrated in Hadoop-trunk-Commit #3073 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3073/])
HDFS-4242. Map.Entry is incorrectly used in LeaseManager since the behavior of it is undefined after the iteration or modifications of the map. (Revision 1415480)
Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1415480
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
> Map.Entry is incorrectly used in LeaseManager
> ---------------------------------------------
>
> Key: HDFS-4242
> URL: https://issues.apache.org/jira/browse/HDFS-4242
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 2.0.3-alpha
>
> Attachments: h4242_20121129.patch
>
>
> As Daryn pointed out, the behavior of [Map.Entry|http://docs.oracle.com/javase/6/docs/api/java/util/Map.Entry.html] is undefined after the iteration or modifications of the map.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4242) Map.Entry is incorrectly used in
LeaseManager
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507021#comment-13507021 ]
Aaron T. Myers commented on HDFS-4242:
--------------------------------------
+1, the patch looks good to me.
> Map.Entry is incorrectly used in LeaseManager
> ---------------------------------------------
>
> Key: HDFS-4242
> URL: https://issues.apache.org/jira/browse/HDFS-4242
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h4242_20121129.patch
>
>
> As Daryn pointed out, the behavior of [Map.Entry|http://docs.oracle.com/javase/6/docs/api/java/util/Map.Entry.html] is undefined after the iteration or modifications of the map.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira