You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/26 08:39:07 UTC
[GitHub] [pulsar] HQebupt opened a new pull request, #16227: [improve][broker][PIP-149]make terminate method async
HQebupt opened a new pull request, #16227:
URL: https://github.com/apache/pulsar/pull/16227
Master Issue: #14013
### Motivation
See #14365
### Verifying this change
Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
If `yes` was chosen, please highlight the changes
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #16227: [improve][broker][PIP-149]make terminate method async
Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #16227:
URL: https://github.com/apache/pulsar/pull/16227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt commented on pull request #16227: [improve][broker][PIP-149]make terminate method async
Posted by GitBox <gi...@apache.org>.
HQebupt commented on PR #16227:
URL: https://github.com/apache/pulsar/pull/16227#issuecomment-1167075570
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #16227: [improve][broker][PIP-149]make terminate method async
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on PR #16227:
URL: https://github.com/apache/pulsar/pull/16227#issuecomment-1167174104
@Technoboy- PTAL again, changes made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on a diff in pull request #16227: [improve][broker][PIP-149]make terminate method async
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on code in PR #16227:
URL: https://github.com/apache/pulsar/pull/16227#discussion_r907016528
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -3606,23 +3606,30 @@ protected CompletableFuture<Void> internalRemoveMaxConsumers(boolean isGlobal) {
}
- protected MessageId internalTerminate(boolean authoritative) {
+ protected CompletableFuture<MessageId> internalTerminateAsync(boolean authoritative) {
+ CompletableFuture<Void> ret;
if (topicName.isGlobal()) {
- validateGlobalNamespaceOwnership(namespaceName);
- }
- PartitionedTopicMetadata partitionMetadata = getPartitionedTopicMetadata(topicName, authoritative, false);
- if (partitionMetadata.partitions > 0) {
- throw new RestException(Status.METHOD_NOT_ALLOWED, "Termination of a partitioned topic is not allowed");
- }
- validateTopicOwnership(topicName, authoritative);
- validateTopicOperation(topicName, TopicOperation.TERMINATE);
- Topic topic = getTopicReference(topicName);
- try {
- return ((PersistentTopic) topic).terminate().get();
- } catch (Exception exception) {
- log.error("[{}] Failed to terminated topic {}", clientAppId(), topicName, exception);
- throw new RestException(exception);
+ ret = validateGlobalNamespaceOwnershipAsync(namespaceName);
+ } else {
+ ret = CompletableFuture.completedFuture(null);
}
+ return ret.thenCompose(__ -> getPartitionedTopicMetadataAsync(topicName, authoritative, false))
Review Comment:
` validateTopicOperationAsync` should be preceded the `getPartitionedTopicMetadataAsync `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt commented on a diff in pull request #16227: [improve][broker][PIP-149]make terminate method async
Posted by GitBox <gi...@apache.org>.
HQebupt commented on code in PR #16227:
URL: https://github.com/apache/pulsar/pull/16227#discussion_r907046618
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -3606,23 +3606,30 @@ protected CompletableFuture<Void> internalRemoveMaxConsumers(boolean isGlobal) {
}
- protected MessageId internalTerminate(boolean authoritative) {
+ protected CompletableFuture<MessageId> internalTerminateAsync(boolean authoritative) {
+ CompletableFuture<Void> ret;
if (topicName.isGlobal()) {
- validateGlobalNamespaceOwnership(namespaceName);
- }
- PartitionedTopicMetadata partitionMetadata = getPartitionedTopicMetadata(topicName, authoritative, false);
- if (partitionMetadata.partitions > 0) {
- throw new RestException(Status.METHOD_NOT_ALLOWED, "Termination of a partitioned topic is not allowed");
- }
- validateTopicOwnership(topicName, authoritative);
- validateTopicOperation(topicName, TopicOperation.TERMINATE);
- Topic topic = getTopicReference(topicName);
- try {
- return ((PersistentTopic) topic).terminate().get();
- } catch (Exception exception) {
- log.error("[{}] Failed to terminated topic {}", clientAppId(), topicName, exception);
- throw new RestException(exception);
+ ret = validateGlobalNamespaceOwnershipAsync(namespaceName);
+ } else {
+ ret = CompletableFuture.completedFuture(null);
}
+ return ret.thenCompose(__ -> getPartitionedTopicMetadataAsync(topicName, authoritative, false))
Review Comment:
Good, also `validateTopicOwnershipAsync` should be preceded `getPartitionedTopicMetadataAsync`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org