[jira] [Resolved] (TS-2082) Remove NON_MODULAR #ifdef and others

["Zhao Yongming (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhao Yongming resolved TS-2082.
-------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 5.0.0)
                   4.2.0

now we have the following remains:
{code}
# define SPLIT_DNS                      1
# define HTTP_CACHE                     1
{code}

for SPLIT_DNS, we should able to remove the splitdns completely after we can define the resolvers in remap.config, keep it until we can accept that feature.

for HTTP_CACHE, it is a clear when you can findout that some codes is mess up with the origin desgin, keep it for developer usage.

so far

> Remove NON_MODULAR #ifdef and others
> ------------------------------------
>
>                 Key: TS-2082
>                 URL: https://issues.apache.org/jira/browse/TS-2082
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Leif Hedstrom
>            Assignee: Zhao Yongming
>              Labels: cleanup
>             Fix For: 4.2.0
>
>         Attachments: 0001-TS-2082-remove-STANDALONE_IOCORE-defines.patch, 0001-fix-build-with-enable-standalone-iocore.patch, 0002-TS-2082-remove-NON_MODULAR-define.patch
>
>
> {code}
> #if TS_HAS_STANDALONE_IOCORE
> # define STANDALONE_IOCORE              1
> #else
> # define FIXME_NONMODULAR               1
> # define SPLIT_DNS                      1
> # define NON_MODULAR                    1
> # define HTTP_CACHE                     1
> #endif
> {code}
> all those ifdefine states relate to some work to make iocore portable to other project, that we don't have any interest right now.
> I think all those define should be cleanup to make codes alive, and we do not need to make a stand alone library right now. when we need to make the iocore into a library, we don't use #ifdefine.
> let us nuke them



--
This message was sent by Atlassian JIRA
(v6.1#6144)