[GitHub] [helix] alirezazamani commented on a change in pull request #1625: Drop current state of the task on disable instances

[GitBox <gi...@apache.org>]

alirezazamani commented on a change in pull request #1625:
URL: https://github.com/apache/helix/pull/1625#discussion_r568179743



##########
File path: helix-core/src/main/java/org/apache/helix/task/AbstractTaskDispatcher.java
##########
@@ -811,13 +816,23 @@ private static void addCompletedTasks(Set<Integer> set, JobContext ctx, Iterable
           || state == TaskPartitionState.DROPPED) {
         filteredTasks.add(partitionNumber);
       }
-      // Allow tasks whose assigned instances are no longer live for rescheduling
+      // Allow tasks whose assigned instances are no longer live or enable for rescheduling
       if (isTaskNotInTerminalState(state)) {
         String assignedParticipant = jobContext.getAssignedParticipant(partitionNumber);
+        final String pName = pName(jobResource, partitionNumber);

Review comment:
       Thanks for the review. Fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org