You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jerryshao <gi...@git.apache.org> on 2017/07/11 21:09:41 UTC
[GitHub] spark pull request #18602: [SPARK-21377][YARN] Add a new configuration to ex...
GitHub user jerryshao opened a pull request:
https://github.com/apache/spark/pull/18602
[SPARK-21377][YARN] Add a new configuration to extend AM classpath in yarn client mode
## What changes were proposed in this pull request?
This PR propose a new configuration "spark.yarn.am.extraClassPath" to extend AM classpath in yarn client mode. The specific scenario is that we have custom `ServiceCredentialProvider` which will be loaded in AM, and this provider requires its additional dependencies to be added in AM classpath.
Using "spark.driver.extraClassPath" (the current code) is not so proper in yarn client mode and if dependency paths are different for driver and AM node, then it is impossible to use this configuration. So instead we add a new configuration to extend AM classpath in yarn client mode.
## How was this patch tested?
UT added and manual verification on local cluster.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerryshao/apache-spark SPARK-21377
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18602.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18602
----
commit 6f9135645cd767e9d69d98157189c2e7ba08a5cc
Author: jerryshao <ss...@hortonworks.com>
Date: 2017-07-11T20:52:22Z
Add a new configuration to extend AM Classpath when running in yarn client mode
Change-Id: I2d9e1c3ab65b648bc1ad321268394e0d15b1eb3f
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18602: [SPARK-21377][YARN] Add a new configuration to extend AM...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18602
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18602: [SPARK-21377][YARN] Add a new configuration to extend AM...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18602
**[Test build #79541 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79541/testReport)** for PR 18602 at commit [`6f91356`](https://github.com/apache/spark/commit/6f9135645cd767e9d69d98157189c2e7ba08a5cc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18602: [SPARK-21377][YARN] Add a new configuration to extend AM...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18602
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79541/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18602: [SPARK-21377][YARN] Add a new configuration to extend AM...
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18602
Thanks @vanzin , based on the comment of JIRA, I will try another approach, so closing it for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18602: [SPARK-21377][YARN] Add a new configuration to extend AM...
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18602
CC @vanzin @tgravescs would you please help to review? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18602: [SPARK-21377][YARN] Add a new configuration to extend AM...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18602
**[Test build #79541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79541/testReport)** for PR 18602 at commit [`6f91356`](https://github.com/apache/spark/commit/6f9135645cd767e9d69d98157189c2e7ba08a5cc).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18602: [SPARK-21377][YARN] Add a new configuration to ex...
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao closed the pull request at:
https://github.com/apache/spark/pull/18602
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18602: [SPARK-21377][YARN] Add a new configuration to extend AM...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/18602
I commented on the bug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org