You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ba...@apache.org on 2008/09/10 23:45:59 UTC

svn commit: r694009 - /james/server/trunk/build-tools/common-build.xml

Author: bago
Date: Wed Sep 10 14:45:58 2008
New Revision: 694009

URL: http://svn.apache.org/viewvc?rev=694009&view=rev
Log:
Include imap jars while building. They are a dependency like anything else from stage.

Modified:
    james/server/trunk/build-tools/common-build.xml

Modified: james/server/trunk/build-tools/common-build.xml
URL: http://svn.apache.org/viewvc/james/server/trunk/build-tools/common-build.xml?rev=694009&r1=694008&r2=694009&view=diff
==============================================================================
--- james/server/trunk/build-tools/common-build.xml (original)
+++ james/server/trunk/build-tools/common-build.xml Wed Sep 10 14:45:58 2008
@@ -233,6 +233,7 @@
                     <include name="${spring.jar}"/>     
                     <include name="${log4j.jar}"/>     
                     <include name="${avalon-phoenix.jar}"/>     
+                    <include name='${path.lib.james}/apache-james-imap*.jar'/>
                 </fileset>   
             </path>   
             <path id='classpath.base.test'>  
@@ -369,6 +370,7 @@
             <delete dir='@{reports}'/>
             <mkdir dir='@{reports}'/>
             <mkdir dir='@{bin}'/>
+        	
             <junit 
                     printsummary="yes" 
                     haltonfailure="yes"  



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: svn commit: r694009 - /james/server/trunk/build-tools/common-build.xml

Posted by Robert Burrell Donkin <ro...@gmail.com>.
On Sat, Sep 13, 2008 at 9:52 PM, Stefano Bagnara <ap...@bago.org> wrote:
> Robert Burrell Donkin ha scritto:
>>
>> On Wed, Sep 10, 2008 at 10:45 PM,  <ba...@apache.org> wrote:
>>>
>>> Author: bago
>>> Date: Wed Sep 10 14:45:58 2008
>>> New Revision: 694009
>>>
>>> URL: http://svn.apache.org/viewvc?rev=694009&view=rev
>>> Log:
>>> Include imap jars while building. They are a dependency like anything
>>> else from stage.
>>
>> one of my aims was to prevent general modules coupling to IMAP
>> directly. IMAP should really be a component deployed within pheonix or
>> spring. that's not really possible ATM but should be possible in the
>> medium term. i would strongly prefer no modules (other than
>> imap-function) to reference code from IMAP.
>
> I don't know the ant build enough to understand how to declare a dependency
> for a function that is inherited by the deployments.
>
> Imap jars are the same identical thing as
> ${mstor.jar}
> ${xstream.jar}
> ${torque.jar}
> ${village.jar}
> ${jackrabbit-api.jar}
> ${jackrabbit-commons.jar}
> ${jackrabbit-rmi.jar}
> ${jcr.jar}
> ${spring.jar}
> ${log4j.jar}
> ${avalon-phoenix.jar}
> ${activemq-core.jar}
> ${jms-spec.jar}
>
> Given that we have all of them in common-build.xml I thought also imap jars
> belong to that file.

some (or many) are in there for historic reasons.

> It would be cool if we had a maven like way to declare local dependencies in
> functions and have them transitively added to the deployment.

it is perfectly possible but i want to work in categories since a
large purpose is to illuminate the coupling in james server so that it
can be fixed. there are some wider and deeper issues so i'll probably
pick this up in a different thread...

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: svn commit: r694009 - /james/server/trunk/build-tools/common-build.xml

Posted by Stefano Bagnara <ap...@bago.org>.
Robert Burrell Donkin ha scritto:
> On Wed, Sep 10, 2008 at 10:45 PM,  <ba...@apache.org> wrote:
>> Author: bago
>> Date: Wed Sep 10 14:45:58 2008
>> New Revision: 694009
>>
>> URL: http://svn.apache.org/viewvc?rev=694009&view=rev
>> Log:
>> Include imap jars while building. They are a dependency like anything else from stage.
> 
> one of my aims was to prevent general modules coupling to IMAP
> directly. IMAP should really be a component deployed within pheonix or
> spring. that's not really possible ATM but should be possible in the
> medium term. i would strongly prefer no modules (other than
> imap-function) to reference code from IMAP.

I don't know the ant build enough to understand how to declare a 
dependency for a function that is inherited by the deployments.

Imap jars are the same identical thing as
${mstor.jar}
${xstream.jar}
${torque.jar}
${village.jar}
${jackrabbit-api.jar}
${jackrabbit-commons.jar}
${jackrabbit-rmi.jar}
${jcr.jar}
${spring.jar}
${log4j.jar}
${avalon-phoenix.jar}
${activemq-core.jar}
${jms-spec.jar}

Given that we have all of them in common-build.xml I thought also imap 
jars belong to that file.

It would be cool if we had a maven like way to declare local 
dependencies in functions and have them transitively added to the 
deployment.

Stefano

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: svn commit: r694009 - /james/server/trunk/build-tools/common-build.xml

Posted by Robert Burrell Donkin <ro...@gmail.com>.
On Wed, Sep 10, 2008 at 10:45 PM,  <ba...@apache.org> wrote:
> Author: bago
> Date: Wed Sep 10 14:45:58 2008
> New Revision: 694009
>
> URL: http://svn.apache.org/viewvc?rev=694009&view=rev
> Log:
> Include imap jars while building. They are a dependency like anything else from stage.

one of my aims was to prevent general modules coupling to IMAP
directly. IMAP should really be a component deployed within pheonix or
spring. that's not really possible ATM but should be possible in the
medium term. i would strongly prefer no modules (other than
imap-function) to reference code from IMAP.

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org