You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by GitBox <gi...@apache.org> on 2019/11/07 22:22:18 UTC

[GitHub] [aurora] ridv commented on issue #93: [Discussion] Port End to End tests away from bash

ridv commented on issue #93: [Discussion] Port End to End tests away from bash
URL: https://github.com/apache/aurora/issues/93#issuecomment-551293654
 
 
   Great points on both counts. Had not heard of Bats so that might be something worth looking into.
   
   @mauri I think for me the main pain points of the current way it is done is when we hit functions like this https://github.com/apache/aurora/blob/master/src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh#L689 which has 8 parameters 😮 This won't change if written in another language but bash syntax is hard to parse in my opinion.
   
   I do think you bring up a good point that a good portion of the script deals with operational stuff.
   
   Maybe we can abstract away the operational stuff to smaller, more pointed bash scripts (i.e. restart and verify that the scheduler came back up), and leave the more intricate stuff (i.e. verifying that a payload is correct) to a python script running the show.
   
   So maybe a combination of the two would be a good idea?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services