[GitHub] [tvm] ashutosh-arm commented on a diff in pull request #11431: [CMSIS-NN] Removed redudant arguments to CMSIS-NN wrapper function

[GitBox <gi...@apache.org>]

ashutosh-arm commented on code in PR #11431:
URL: https://github.com/apache/tvm/pull/11431#discussion_r881415727


##########
src/relay/backend/contrib/cmsisnn/relay_to_tir.cc:
##########
@@ -757,7 +778,10 @@ class RelayToTIRVisitor : public MixedModeMutator {
   static constexpr int32_t kScaledDiffIntegerBits = 5;
   static constexpr int32_t kInputBits = 5;
   static constexpr double kBeta = 1.0;
+  /*! \brief Unique id for context buffer needed by CMSIS-NN layers. */
   int32_t context_buffer_id_;
+  /*! \brief Skip arguments in the call to global partitioned function. */
+  std::list<int32_t> skip_call_args_;

Review Comment:
   It was supposed to have only 2 elements. But, I have modified it now.



##########
src/relay/backend/contrib/cmsisnn/relay_to_tir.cc:
##########
@@ -141,18 +141,24 @@ class RelayToTIRVisitor : public MixedModeMutator {
     // %3 = qnn.requantize(%2, %input_scale_const_4, %cmsisnn_shift_const_5,
     //                     %output_scale_scalar, %output_zero_point_scalar)
     // clip(%3, a_min=%min_scalar, a_max=%max_scalar)
+    int filter_scale_pos = 3;

Review Comment:
   ACK



##########
src/relay/backend/contrib/cmsisnn/relay_to_tir.cc:
##########
@@ -141,18 +141,24 @@ class RelayToTIRVisitor : public MixedModeMutator {
     // %3 = qnn.requantize(%2, %input_scale_const_4, %cmsisnn_shift_const_5,
     //                     %output_scale_scalar, %output_zero_point_scalar)
     // clip(%3, a_min=%min_scalar, a_max=%max_scalar)
+    int filter_scale_pos = 3;
+    int input_scale_pos = 4;

Review Comment:
   ACK



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org