You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2020/10/07 14:19:17 UTC
[kudu-CR] Upgrade Bootstrap to 3.4.1 in web UI
Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/16556
to review the following change.
Change subject: Upgrade Bootstrap to 3.4.1 in web UI
......................................................................
Upgrade Bootstrap to 3.4.1 in web UI
The web UI has been using Bootstrap 3.3.7 which is affected by multiple
XSS vulnerability CVEs: https://snyk.io/vuln/npm:bootstrap
This patch upgrades Bootstrap to 3.4.1 which is the latest 3.x release
of Bootstrap.
Change-Id: I0b92241457af2997b3486781dc5e9e5f9e971471
---
A www/bootstrap/css/bootstrap-theme.css
A www/bootstrap/css/bootstrap-theme.css.map
A www/bootstrap/css/bootstrap-theme.min.css
A www/bootstrap/css/bootstrap-theme.min.css.map
A www/bootstrap/css/bootstrap.css
A www/bootstrap/css/bootstrap.css.map
M www/bootstrap/css/bootstrap.min.css
A www/bootstrap/css/bootstrap.min.css.map
A www/bootstrap/fonts/glyphicons-halflings-regular.eot
A www/bootstrap/fonts/glyphicons-halflings-regular.svg
A www/bootstrap/fonts/glyphicons-halflings-regular.ttf
A www/bootstrap/fonts/glyphicons-halflings-regular.woff2
A www/bootstrap/js/bootstrap.js
M www/bootstrap/js/bootstrap.min.js
A www/bootstrap/js/npm.js
15 files changed, 10,318 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/16556/1
--
To view, visit http://gerrit.cloudera.org:8080/16556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b92241457af2997b3486781dc5e9e5f9e971471
Gerrit-Change-Number: 16556
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] Upgrade Bootstrap to 3.4.1 in web UI
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16556 )
Change subject: Upgrade Bootstrap to 3.4.1 in web UI
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16556/1/www/bootstrap/js/npm.js
File www/bootstrap/js/npm.js:
PS1:
> Do we need this file imported as well?
I don't think this is necessary, it seems to work fine without it, no errors logged to the console either. It was in the archive though, do you think I should remove it?
--
To view, visit http://gerrit.cloudera.org:8080/16556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b92241457af2997b3486781dc5e9e5f9e971471
Gerrit-Change-Number: 16556
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 07 Oct 2020 17:38:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade Bootstrap to 3.4.1 in web UI
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16556
to look at the new patch set (#2).
Change subject: Upgrade Bootstrap to 3.4.1 in web UI
......................................................................
Upgrade Bootstrap to 3.4.1 in web UI
The web UI has been using Bootstrap 3.3.7 which is affected by multiple
XSS vulnerability CVEs: https://snyk.io/vuln/npm:bootstrap
This patch upgrades Bootstrap to 3.4.1 which is the latest 3.x release
of Bootstrap.
Change-Id: I0b92241457af2997b3486781dc5e9e5f9e971471
---
A www/bootstrap/css/bootstrap-theme.min.css
A www/bootstrap/css/bootstrap-theme.min.css.map
M www/bootstrap/css/bootstrap.min.css
A www/bootstrap/css/bootstrap.min.css.map
A www/bootstrap/fonts/glyphicons-halflings-regular.eot
A www/bootstrap/fonts/glyphicons-halflings-regular.svg
A www/bootstrap/fonts/glyphicons-halflings-regular.ttf
A www/bootstrap/fonts/glyphicons-halflings-regular.woff2
M www/bootstrap/js/bootstrap.min.js
9 files changed, 302 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/16556/2
--
To view, visit http://gerrit.cloudera.org:8080/16556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0b92241457af2997b3486781dc5e9e5f9e971471
Gerrit-Change-Number: 16556
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Upgrade Bootstrap to 3.4.1 in web UI
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16556 )
Change subject: Upgrade Bootstrap to 3.4.1 in web UI
......................................................................
Patch Set 2:
(1 comment)
> Patch Set 1:
>
> Do we want/need to non `min` versions of the files?
We don't need them, as per the discussion about npm.js, I removed these as well.
http://gerrit.cloudera.org:8080/#/c/16556/1/www/bootstrap/js/npm.js
File www/bootstrap/js/npm.js:
PS1:
> I guess it's desirable to import as less as possible to keep it functional,
Fair enough, removed it.
--
To view, visit http://gerrit.cloudera.org:8080/16556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b92241457af2997b3486781dc5e9e5f9e971471
Gerrit-Change-Number: 16556
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 08 Oct 2020 06:44:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade Bootstrap to 3.4.1 in web UI
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16556 )
Change subject: Upgrade Bootstrap to 3.4.1 in web UI
......................................................................
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b92241457af2997b3486781dc5e9e5f9e971471
Gerrit-Change-Number: 16556
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 09 Oct 2020 13:49:20 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Bootstrap to 3.4.1 in web UI
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16556 )
Change subject: Upgrade Bootstrap to 3.4.1 in web UI
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b92241457af2997b3486781dc5e9e5f9e971471
Gerrit-Change-Number: 16556
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 07 Oct 2020 16:52:24 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Bootstrap to 3.4.1 in web UI
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16556 )
Change subject: Upgrade Bootstrap to 3.4.1 in web UI
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b92241457af2997b3486781dc5e9e5f9e971471
Gerrit-Change-Number: 16556
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 09 Oct 2020 17:52:02 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Bootstrap to 3.4.1 in web UI
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: Upgrade Bootstrap to 3.4.1 in web UI
......................................................................
Removed Code-Review+2 by Grant Henke <gr...@apache.org>
--
To view, visit http://gerrit.cloudera.org:8080/16556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I0b92241457af2997b3486781dc5e9e5f9e971471
Gerrit-Change-Number: 16556
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Upgrade Bootstrap to 3.4.1 in web UI
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: Upgrade Bootstrap to 3.4.1 in web UI
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I0b92241457af2997b3486781dc5e9e5f9e971471
Gerrit-Change-Number: 16556
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Upgrade Bootstrap to 3.4.1 in web UI
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16556 )
Change subject: Upgrade Bootstrap to 3.4.1 in web UI
......................................................................
Patch Set 1:
Do we want/need to non `min` versions of the files?
--
To view, visit http://gerrit.cloudera.org:8080/16556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b92241457af2997b3486781dc5e9e5f9e971471
Gerrit-Change-Number: 16556
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 07 Oct 2020 17:34:04 +0000
Gerrit-HasComments: No
[kudu-CR] Upgrade Bootstrap to 3.4.1 in web UI
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16556
to look at the new patch set (#3).
Change subject: Upgrade Bootstrap to 3.4.1 in web UI
......................................................................
Upgrade Bootstrap to 3.4.1 in web UI
The web UI has been using Bootstrap 3.3.7 which is affected by multiple
XSS vulnerability CVEs: https://snyk.io/vuln/npm:bootstrap
This patch upgrades Bootstrap to 3.4.1 which is the latest 3.x release
of Bootstrap.
Change-Id: I0b92241457af2997b3486781dc5e9e5f9e971471
---
A www/bootstrap/css/bootstrap-theme.min.css
A www/bootstrap/css/bootstrap-theme.min.css.map
M www/bootstrap/css/bootstrap.min.css
A www/bootstrap/css/bootstrap.min.css.map
M www/bootstrap/js/bootstrap.min.js
5 files changed, 14 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/16556/3
--
To view, visit http://gerrit.cloudera.org:8080/16556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0b92241457af2997b3486781dc5e9e5f9e971471
Gerrit-Change-Number: 16556
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Upgrade Bootstrap to 3.4.1 in web UI
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16556 )
Change subject: Upgrade Bootstrap to 3.4.1 in web UI
......................................................................
Upgrade Bootstrap to 3.4.1 in web UI
The web UI has been using Bootstrap 3.3.7 which is affected by multiple
XSS vulnerability CVEs: https://snyk.io/vuln/npm:bootstrap
This patch upgrades Bootstrap to 3.4.1 which is the latest 3.x release
of Bootstrap.
Change-Id: I0b92241457af2997b3486781dc5e9e5f9e971471
Reviewed-on: http://gerrit.cloudera.org:8080/16556
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
A www/bootstrap/css/bootstrap-theme.min.css
A www/bootstrap/css/bootstrap-theme.min.css.map
M www/bootstrap/css/bootstrap.min.css
A www/bootstrap/css/bootstrap.min.css.map
M www/bootstrap/js/bootstrap.min.js
5 files changed, 14 insertions(+), 7 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b92241457af2997b3486781dc5e9e5f9e971471
Gerrit-Change-Number: 16556
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Upgrade Bootstrap to 3.4.1 in web UI
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16556 )
Change subject: Upgrade Bootstrap to 3.4.1 in web UI
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16556/1/www/bootstrap/js/npm.js
File www/bootstrap/js/npm.js:
PS1:
Do we need this file imported as well?
It lists many files as required, but they are missing in our clone of bootstrap. Or the plan is to add them later on?
--
To view, visit http://gerrit.cloudera.org:8080/16556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b92241457af2997b3486781dc5e9e5f9e971471
Gerrit-Change-Number: 16556
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 07 Oct 2020 17:06:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade Bootstrap to 3.4.1 in web UI
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16556 )
Change subject: Upgrade Bootstrap to 3.4.1 in web UI
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16556/1/www/bootstrap/js/npm.js
File www/bootstrap/js/npm.js:
PS1:
> I don't think this is necessary, it seems to work fine without it, no error
I guess it's desirable to import as less as possible to keep it functional, unless it requires some non-trivial cherry-picking and patching.
From that standpoint I'd simply remove this file since it's not going to be used by Kudu anyways.
--
To view, visit http://gerrit.cloudera.org:8080/16556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b92241457af2997b3486781dc5e9e5f9e971471
Gerrit-Change-Number: 16556
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 07 Oct 2020 18:14:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] Upgrade Bootstrap to 3.4.1 in web UI
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16556 )
Change subject: Upgrade Bootstrap to 3.4.1 in web UI
......................................................................
Patch Set 2:
> Patch Set 2:
>
> (1 comment)
>
> > Patch Set 1:
> >
> > Do we want/need to non `min` versions of the files?
>
> We don't need them, as per the discussion about npm.js, I removed these as well.
Actually, I'm not even sure we need the glyph icons font, don't remember having seen any of them and Chrome doesn't seem to load any fonts on the web UI. I removed the other formats of the font but left the "woff" version.
--
To view, visit http://gerrit.cloudera.org:8080/16556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b92241457af2997b3486781dc5e9e5f9e971471
Gerrit-Change-Number: 16556
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 08 Oct 2020 06:53:54 +0000
Gerrit-HasComments: No