You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Ja...@rzf.fin-nrw.de on 2004/09/01 12:40:50 UTC
AW: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Copy.j
ava
1. Copy has also other protected variables
2. refactoring via getter is possible (but not as fast :)
3. I wanted to fix the gumpy-message as fast as possible (and you know
the refactoring tools of notepad ;-)
Jan
> -----Ursprüngliche Nachricht-----
> Von: Antoine Levy-Lambert [mailto:antoine@gmx.de]
> Gesendet am: Mittwoch, 1. September 2004 12:16
> An: Ant Developers List
> Betreff: Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs
> Copy.java
>
> Hello Jan,
> I thought we wanted to have fields always private.
> This is what checkstyle checks.
> Cheers,
> Antoine
>
> > jhm 2004/09/01 00:02:23
> >
> > Modified: src/main/org/apache/tools/ant/taskdefs Tag:
> ANT_16_BRANCH
> > Copy.java
> > Log:
> > Let <move> compile.
> >
> > Revision Changes Path
> > No revision
> > No revision
> > 1.66.2.6 +2 -2
> > ant/src/main/org/apache/tools/ant/taskdefs/Copy.java
> >
> > Index: Copy.java
> >
> ===================================================================
> > RCS file:
> > /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/Copy.java,v
> > retrieving revision 1.66.2.5
> > retrieving revision 1.66.2.6
> > diff -u -r1.66.2.5 -r1.66.2.6
> > --- Copy.java 25 May 2004 12:12:56 -0000 1.66.2.5
> > +++ Copy.java 1 Sep 2004 07:02:23 -0000 1.66.2.6
> > @@ -66,7 +66,7 @@
> > protected boolean flatten = false;
> > protected int verbosity = Project.MSG_VERBOSE;
> > protected boolean includeEmpty = true;
> > - private boolean failonerror = true;
> > + protected boolean failonerror = true;
> >
> > protected Hashtable fileCopyMap = new Hashtable();
> > protected Hashtable dirCopyMap = new Hashtable();
> >
> >
> >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> > For additional commands, e-mail: dev-help@ant.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>